Fix the logic that determines when to show the Win 10 promo page.

Fix the logic that determines when to show the Win 10 promo page.

The Win 10 promo is now skipped when the DefaultBrowserSettingEnabled
group policy is disabled or the browser distribution does not allow
Chrome to be set as the default browser.

BUG=679816
Review-Url: https://codereview.chromium.org/2625793002
Cr-Commit-Position: refs/heads/master@{#442943}
Committed: https://chromium.googlesource.com/chromium/src/+/5b44f57323919c2838778c41b3eb00d7d0f0e7b2

[Patrick Monette, 2017-01-10 21:21:11]

Patchset #1 (id:1) has been deleted

[Patrick Monette, 2017-01-10 21:30:01]

Patchset #1 (id:20001) has been deleted

[Patrick Monette, 2017-01-10 21:30:14]

pmonette@chromium.org changed reviewers:
+ pkasting@chromium.org

[Patrick Monette, 2017-01-10 21:30:15]

Hi! PTAL.

[Peter Kasting, 2017-01-11 01:06:09]

LGTM

https://codereview.chromium.org/2625793002/diff/40001/chrome/browser/ui/start...
File chrome/browser/ui/startup/startup_tab_provider.cc (right):

https://codereview.chromium.org/2625793002/diff/40001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_tab_provider.cc:38: bool
allowed_by_distribution = shell_integration::CanSetAsDefaultBrowser();
Nit: I'd just inline this below

https://codereview.chromium.org/2625793002/diff/40001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_tab_provider.cc:62: bool
set_default_browser_allowed = IsSetDefaultBrowserAllowed(local_state);
Nit: I'd just inline this below, or else I'd inline IsSetDefaultBrowserAllowed
to here (and probably keep this temp)

[Patrick Monette, 2017-01-11 16:41:20]

Thanks!

https://codereview.chromium.org/2625793002/diff/40001/chrome/browser/ui/start...
File chrome/browser/ui/startup/startup_tab_provider.cc (right):

https://codereview.chromium.org/2625793002/diff/40001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_tab_provider.cc:38: bool
allowed_by_distribution = shell_integration::CanSetAsDefaultBrowser();
On 2017/01/11 01:06:09, Peter Kasting wrote:
> Nit: I'd just inline this below

I inlined the whole function below.

https://codereview.chromium.org/2625793002/diff/40001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_tab_provider.cc:62: bool
set_default_browser_allowed = IsSetDefaultBrowserAllowed(local_state);
On 2017/01/11 01:06:09, Peter Kasting wrote:
> Nit: I'd just inline this below, or else I'd inline IsSetDefaultBrowserAllowed
> to here (and probably keep this temp)

Done.

[Patrick Monette, 2017-01-11 16:41:40]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2017-01-11 16:41:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2625793002/#ps60001
(title: "Rebase   comments   add braces")

[commit-bot: I haz the power, 2017-01-11 16:41:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 17:25:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484152900313840,
"parent_rev": "6f65f265993acc4c08ae68de725a65ccddc6b45e", "commit_rev":
"5b44f57323919c2838778c41b3eb00d7d0f0e7b2"}

[commit-bot: I haz the power, 2017-01-11 17:26:11]

Description was changed from

==========
Fix the logic that determines when to show the Win 10 promo page.

The Win 10 promo is now skipped when the DefaultBrowserSettingEnabled
group policy is disabled or the browser distribution does not allow
Chrome to be set as the default browser.

BUG=679816
==========

to

==========
Fix the logic that determines when to show the Win 10 promo page.

The Win 10 promo is now skipped when the DefaultBrowserSettingEnabled
group policy is disabled or the browser distribution does not allow
Chrome to be set as the default browser.

BUG=679816

Review-Url: https://codereview.chromium.org/2625793002
Cr-Commit-Position: refs/heads/master@{#442943}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b44f57323919c2838778c41b3eb...
==========

[commit-bot: I haz the power, 2017-01-11 17:26:12]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5b44f57323919c2838778c41b3eb...