Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2625783002: Explicitly compute analysis results for sources to check errors. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Explicitly compute analysis results for sources to check errors. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/65ff5b5e50589287243294d4bc3f50645725306a

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rollback await(ing) of assertErrors(). Format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3671 lines, -2064 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart View 1 41 chunks +86 lines, -43 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 425 chunks +970 lines, -638 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 1 16 chunks +34 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 275 chunks +593 lines, -298 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 442 chunks +926 lines, -466 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 1 88 chunks +189 lines, -94 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 55 chunks +110 lines, -57 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 13 chunks +53 lines, -27 lines 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 1 65 chunks +130 lines, -68 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 242 chunks +520 lines, -312 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 12 chunks +29 lines, -19 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 1 22 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 11 months ago (2017-01-10 20:36:29 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2625783002/diff/1/pkg/analyzer/test/generated/compile_time_error_code_test.dart File pkg/analyzer/test/generated/compile_time_error_code_test.dart (right): https://codereview.chromium.org/2625783002/diff/1/pkg/analyzer/test/generated/compile_time_error_code_test.dart#newcode1564 pkg/analyzer/test/generated/compile_time_error_code_test.dart:1564: await assertErrors(source2, [CompileTimeErrorCode.CONST_WITH_NON_TYPE]); We have typically added a ...
3 years, 11 months ago (2017-01-10 20:53:34 UTC) #2
scheglov
I reformatted tests. https://codereview.chromium.org/2625783002/diff/1/pkg/analyzer/test/generated/compile_time_error_code_test.dart File pkg/analyzer/test/generated/compile_time_error_code_test.dart (right): https://codereview.chromium.org/2625783002/diff/1/pkg/analyzer/test/generated/compile_time_error_code_test.dart#newcode1564 pkg/analyzer/test/generated/compile_time_error_code_test.dart:1564: await assertErrors(source2, [CompileTimeErrorCode.CONST_WITH_NON_TYPE]); On 2017/01/10 20:53:34, ...
3 years, 11 months ago (2017-01-10 20:57:16 UTC) #3
scheglov
3 years, 11 months ago (2017-01-10 20:59:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
65ff5b5e50589287243294d4bc3f50645725306a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698