Explicitly compute analysis results for sources to check errors.

pkg/analyzer/test/generated/non_hint_code_test.dart

Index: pkg/analyzer/test/generated/non_hint_code_test.dart
diff --git a/pkg/analyzer/test/generated/non_hint_code_test.dart b/pkg/analyzer/test/generated/non_hint_code_test.dart
index b3a88377ea6d4174041fd838a90512c236280f5e..308fd880d455d49a610443a5065c4bad7fef8443 100644
--- a/pkg/analyzer/test/generated/non_hint_code_test.dart
+++ b/pkg/analyzer/test/generated/non_hint_code_test.dart
@@ -32,7 +32,8 @@ class B extends A {
   }
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -50,7 +51,8 @@ f() {
   throw 'foo';
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -60,7 +62,8 @@ const bool DEBUG = true;
 f() {
   DEBUG ? 1 : 2;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -70,7 +73,8 @@ const bool DEBUG = false;
 f() {
   DEBUG ? 1 : 2;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -80,7 +84,8 @@ const bool DEBUG = true;
 f() {
   if(DEBUG) {} else {}
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -92,7 +97,8 @@ class A {
 f() {
   if(A.DEBUG) {}
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -110,7 +116,8 @@ library lib2;
 class A {
   static const bool DEBUG = false;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -128,7 +135,8 @@ library lib2;
 class A {
   static const bool DEBUG = false;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -138,7 +146,8 @@ const bool DEBUG = false;
 f() {
   if(DEBUG) {}
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -148,7 +157,8 @@ const bool DEBUG = false;
 f() {
   while(DEBUG) {}
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -159,7 +169,8 @@ class B extends A {}
 f() {
   try {} on B catch (e) {} on A catch (e) {} catch (e) {}
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -178,7 +189,8 @@ f() {
     break;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -188,7 +200,8 @@ const bool DEBUG = false;
 f() {
   bool b = DEBUG && false;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -198,7 +211,8 @@ const bool DEBUG = true;
 f() {
   bool b = DEBUG || true;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -210,7 +224,8 @@ f() {
   }
   int a = 1;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -226,7 +241,8 @@ class C {
   }
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -240,7 +256,8 @@ g() {
   f();
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -258,7 +275,8 @@ class C {
   }
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -274,7 +292,8 @@ class C {
   }
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -291,7 +310,8 @@ class C {
   }
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -300,7 +320,8 @@ class C {
 f(int x, int y) {
   var v = x / y.toInt();
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -309,7 +330,8 @@ f(int x, int y) {
 f(x, y) {
   var v = (x / y).toInt();
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -321,7 +343,8 @@ class A {
 f(A x, A y) {
   var v = (x / y).toInt();
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -337,7 +360,8 @@ one.A a2;''');
         r'''
 library lib1;
 class A {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -354,7 +378,8 @@ B b;''');
 library lib1;
 class A {}
 class B {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -371,7 +396,8 @@ B b;''');
 library lib1;
 class A {}
 class B {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -396,7 +422,8 @@ f(var message, var dynamic_) {
   }
   int s = message;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -412,7 +439,8 @@ f(var message) {
   }
   int s = message;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -427,7 +455,8 @@ f(var message) {
   }
   String s = message;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -436,25 +465,29 @@ f(var message) {
 abstract class A {
   int m();
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
   test_missingReturn_expressionFunctionBody() async {
     Source source = addSource("int f() => 0;");
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
   test_missingReturn_noReturnType() async {
     Source source = addSource("f() {}");
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
   test_missingReturn_voidReturnType() async {
     Source source = addSource("void f() {}");
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -464,7 +497,8 @@ m(x) {
   for (var v = x; ; v++) {}
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -474,7 +508,8 @@ m(x) {
   if (x?.y == null) {}
 }
 ''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -484,7 +519,8 @@ class A {
   bool operator ==(x) { return x; }
   get hashCode => 0;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -503,7 +539,8 @@ class B implements A {
   @override
   int c;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -522,7 +559,8 @@ class B extends A {
   @override
   int c;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -535,7 +573,8 @@ class B implements A {
   @override
   int get m => 1;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -548,7 +587,8 @@ class B extends A {
   @override
   int get m => 1;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -561,7 +601,8 @@ class B implements A {
   @override
   int m() => 1;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -574,7 +615,8 @@ class B extends A {
   @override
   int m() => 1;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -587,7 +629,8 @@ class B extends A {
   @override
   int m() => 1;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -600,7 +643,8 @@ class B implements A {
   @override
   set m(int x) {}
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -613,7 +657,8 @@ class B extends A {
   @override
   set m(int x) {}
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -629,7 +674,8 @@ class Z {
     y.x.add(new A());
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -647,7 +693,8 @@ f(var a) {
   a++;
   ++a;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_proxy_annotation_prefixed2() async {
@@ -666,7 +713,8 @@ class B {
     ++a;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_proxy_annotation_prefixed3() async {
@@ -685,7 +733,8 @@ class B {
 }
 @proxy
 class A {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedGetter_inSubtype() async {
@@ -699,7 +748,8 @@ f(var a) {
     return a.b;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedMethod_assignmentExpression_inSubtype() async {
@@ -713,7 +763,8 @@ f(var a, var a2) {
   a2 = new A();
   a += a2;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedMethod_dynamic() async {
@@ -722,7 +773,8 @@ class D<T extends dynamic> {
   fieldAccess(T t) => t.abc;
   methodAccess(T t) => t.xyz(1, 2, 'three');
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedMethod_inSubtype() async {
@@ -735,7 +787,8 @@ f() {
   var a = new A();
   a.b();
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedMethod_unionType_all() async {
@@ -755,7 +808,8 @@ f(A a, B b) {
   }
   ab.m();
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedMethod_unionType_some() async {
@@ -773,7 +827,8 @@ f(A a, B b) {
   }
   ab.m(0);
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedOperator_binaryExpression_inSubtype() async {
@@ -787,7 +842,8 @@ f(var a) {
     a + 1;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedOperator_indexBoth_inSubtype() async {
@@ -801,7 +857,8 @@ f(var a) {
     a[0]++;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedOperator_indexGetter_inSubtype() async {
@@ -815,7 +872,8 @@ f(var a) {
     a[0];
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedOperator_indexSetter_inSubtype() async {
@@ -829,7 +887,8 @@ f(var a) {
     a[0] = 1;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedOperator_postfixExpression() async {
@@ -843,7 +902,8 @@ f(var a) {
     a++;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedOperator_prefixExpression() async {
@@ -857,7 +917,8 @@ f(var a) {
     ++a;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_undefinedSetter_inSubtype() async {
@@ -871,7 +932,8 @@ f(var a) {
     a.b = 0;
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_unnecessaryCast_13855_parameter_A() async {
@@ -886,7 +948,8 @@ class B<E> {
     (e as A).a();
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -898,7 +961,8 @@ class B implements I {}
 I m(A a, B b) {
   return a == null ? b as I : a as I;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -907,7 +971,8 @@ I m(A a, B b) {
 m(v) {
   var b = v as Object;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -919,7 +984,8 @@ Future<int> f() => new Future.value(0);
 void g(bool c) {
   (c ? f(): new Future.value(0) as Future<int>).then((int value) {});
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -928,7 +994,8 @@ void g(bool c) {
 m(v) {
   var b = Object as dynamic;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -943,7 +1010,8 @@ class B extends A {
     print(y);
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -959,7 +1027,8 @@ class B extends A {
     return super.noSuchMethod(y);
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -972,7 +1041,8 @@ class B extends A {
   mmm();
   noSuchMethod(y) => super.hashCode;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -985,7 +1055,8 @@ class B extends A {
   mmm();
   noSuchMethod(y) => 42;
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1001,7 +1072,9 @@ library lib1;
 class A {
   const A() {}
 }''');
-    await assertErrors(source);
+    await computeAnalysisResult(source);
+    await computeAnalysisResult(source2);
+    assertErrors(source);
     verify([source, source2]);
   }
 
@@ -1023,9 +1096,12 @@ class A {}''');
         r'''
 library lib2;
 class B {}''');
-    await assertErrors(source);
-    await assertNoErrors(source2);
-    await assertNoErrors(source3);
+    await computeAnalysisResult(source);
+    await computeAnalysisResult(source2);
+    await computeAnalysisResult(source3);
+    assertErrors(source);
+    assertNoErrors(source2);
+    assertNoErrors(source3);
     verify([source, source2, source3]);
   }
 
@@ -1033,7 +1109,8 @@ class B {}''');
     Source source = addSource(r'''
 library L;
 import 'dart:core';''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1053,7 +1130,8 @@ class One {}''');
         r'''
 library lib2;
 class Two {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1079,7 +1157,8 @@ class Two {}''');
         r'''
 library lib3;
 class Three {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1106,7 +1185,8 @@ class Two {}''');
 library lib3;
 export 'lib2.dart';
 class Three {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1124,7 +1204,8 @@ class A {
         r'''
 library lib1;
 const x = 0;''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1145,7 +1226,8 @@ class A {
 library lib1;
 class One {}
 topLevelFunction() {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1168,7 +1250,8 @@ class A {
 library lib1;
 class One {}
 topLevelFunction() {}''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1180,7 +1263,8 @@ class A {
     var a = f();
   }
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -1190,7 +1274,8 @@ int f() => 1;
 g() {
   var a = f();
 }''');
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
     verify([source]);
   }
 }
@@ -1198,12 +1283,14 @@ g() {
 class PubSuggestionCodeTest extends ResolverTestCase {
   test_import_package() async {
     Source source = addSource("import 'package:somepackage/other.dart';");
-    await assertErrors(source, [CompileTimeErrorCode.URI_DOES_NOT_EXIST]);
+    await computeAnalysisResult(source);
+    assertErrors(source, [CompileTimeErrorCode.URI_DOES_NOT_EXIST]);
   }
 
   test_import_packageWithDotDot() async {
     Source source = addSource("import 'package:somepackage/../other.dart';");
-    await assertErrors(source, [
+    await computeAnalysisResult(source);
+    assertErrors(source, [
       CompileTimeErrorCode.URI_DOES_NOT_EXIST,
       HintCode.PACKAGE_IMPORT_CONTAINS_DOT_DOT
     ]);
@@ -1211,7 +1298,8 @@ class PubSuggestionCodeTest extends ResolverTestCase {
 
   test_import_packageWithLeadingDotDot() async {
     Source source = addSource("import 'package:../other.dart';");
-    await assertErrors(source, [
+    await computeAnalysisResult(source);
+    assertErrors(source, [
       CompileTimeErrorCode.URI_DOES_NOT_EXIST,
       HintCode.PACKAGE_IMPORT_CONTAINS_DOT_DOT
     ]);
@@ -1222,7 +1310,8 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
         addNamedSource("/myproj/web/test.dart", "import '../lib/other.dart';");
-    await assertErrors(
+    await computeAnalysisResult(source);
+    assertErrors(
         source, [HintCode.FILE_IMPORT_OUTSIDE_LIB_REFERENCES_FILE_INSIDE]);
   }
 
@@ -1230,7 +1319,8 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
         addNamedSource("/myproj/web/test.dart", "import '../lib/other.dart';");
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_import_referenceOutOfLibDirectory() async {
@@ -1238,7 +1328,8 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/web/other.dart", "");
     Source source =
         addNamedSource("/myproj/lib/test.dart", "import '../web/other.dart';");
-    await assertErrors(
+    await computeAnalysisResult(source);
+    assertErrors(
         source, [HintCode.FILE_IMPORT_INSIDE_LIB_REFERENCES_FILE_OUTSIDE]);
   }
 
@@ -1246,7 +1337,8 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/web/other.dart", "");
     Source source =
         addNamedSource("/myproj/lib/test.dart", "import '../web/other.dart';");
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_import_valid_inside_lib1() async {
@@ -1254,7 +1346,8 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
         addNamedSource("/myproj/lib/test.dart", "import 'other.dart';");
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_import_valid_inside_lib2() async {
@@ -1262,7 +1355,8 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/lib/bar/other.dart", "");
     Source source = addNamedSource(
         "/myproj/lib/foo/test.dart", "import '../bar/other.dart';");
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 
   test_import_valid_outside_lib() async {
@@ -1270,6 +1364,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/web/other.dart", "");
     Source source =
         addNamedSource("/myproj/lib2/test.dart", "import '../web/other.dart';");
-    await assertNoErrors(source);
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
   }
 }