Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2625753002: Correct the comment for ParseIconPurpose in manifest_parser.h (Closed)

Created:
3 years, 11 months ago by F
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, mlamouri+watch-manifest_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct the comment for ParseIconPurpose in manifest_parser.h Review-Url: https://codereview.chromium.org/2625753002 Cr-Commit-Position: refs/heads/master@{#442877} Committed: https://chromium.googlesource.com/chromium/src/+/4120687aabe4503289688f3d4423ffbcad5b70ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/renderer/manifest/manifest_parser.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
F
Hi Mounir, PTAL. Thanks!
3 years, 11 months ago (2017-01-10 19:13:43 UTC) #2
mlamouri (slow - plz ping)
lgtm
3 years, 11 months ago (2017-01-11 11:18:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625753002/1
3 years, 11 months ago (2017-01-11 11:18:20 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 12:05:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4120687aabe4503289688f3d4423...

Powered by Google App Engine
This is Rietveld 408576698