Rename Enqueuer.universe to worldBuilder.

Rename Enqueuer.universe to worldBuilder.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/eac4142d42b9b97d4fd81f7e3381c8d3f3f6bcc2

[Johnni Winther, 2017-01-10 15:33:57]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-11 23:54:56]

lgtm

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/js_interop_analysis.dart (right):

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/js_interop_analysis.dart:120: if
(!backend.compiler.resolutionWorldBuilder.isImplemented(classElement))
we might need to add {} here since it's no longer a 1-line

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:10: final
CodegenWorldBuilder codegenWorldBuilder;
fwiw, given that the type says what it is - I'm ok using just worldBuilder here
(at least in this file there is no ambiguity)

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/program_builder/collector.dart (right):

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/program_builder/collector.dart:181:
.codegenWorldBuilder.directlyInstantiatedClasses
similar to my other question about the namer - it feels liek by the time we
reach this point, we are dealing with the closed world again and not a builder.
Should these API move to the (now refined) closed world?

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
(right):

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:357: var
selectors = _compiler.codegenWorldBuilder
can we directly use worldBuilder here and everywhere below (seems like the
getter above is in scope here)

[Johnni Winther, 2017-01-12 12:20:13]

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/js_interop_analysis.dart (right):

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/js_interop_analysis.dart:120: if
(!backend.compiler.resolutionWorldBuilder.isImplemented(classElement))
On 2017/01/11 23:54:56, Siggi Cherem (dart-lang) wrote:
> we might need to add {} here since it's no longer a 1-line

Done.

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:10: final
CodegenWorldBuilder codegenWorldBuilder;
On 2017/01/11 23:54:56, Siggi Cherem (dart-lang) wrote:
> fwiw, given that the type says what it is - I'm ok using just worldBuilder
here
> (at least in this file there is no ambiguity)

Done.

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/program_builder/collector.dart (right):

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/program_builder/collector.dart:181:
.codegenWorldBuilder.directlyInstantiatedClasses
On 2017/01/11 23:54:56, Siggi Cherem (dart-lang) wrote:
> similar to my other question about the namer - it feels liek by the time we
> reach this point, we are dealing with the closed world again and not a
builder.
> Should these API move to the (now refined) closed world?

Not yet. Added a TODO.

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
(right):

https://codereview.chromium.org/2625713002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:357: var
selectors = _compiler.codegenWorldBuilder
On 2017/01/11 23:54:56, Siggi Cherem (dart-lang) wrote:
> can we directly use worldBuilder here and everywhere below (seems like the
> getter above is in scope here)

Done.

[Johnni Winther, 2017-01-12 12:27:14]

Description was changed from

==========
Rename Enqueuer.universe to worldBuilder.
==========

to

==========
Rename Enqueuer.universe to worldBuilder.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eac4142d42b9b97d4fd81f7e3381c8d3f3f6bcc2
==========

[Johnni Winther, 2017-01-12 12:27:15]

Committed patchset #3 (id:40001) manually as
eac4142d42b9b97d4fd81f7e3381c8d3f3f6bcc2 (presubmit successful).