Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4273)

Unified Diff: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html

Issue 2625663003: Layout nits for the signin email confirmation dialog. (Closed)
Patch Set: Remove unnecessary margin Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html
diff --git a/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html b/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html
index c81130284be54ce4cdfb5aa0215e3d92b69421c8..8cf9053053dc7cfb710ddda9e79d016ace75632c 100644
--- a/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html
+++ b/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html
@@ -15,9 +15,32 @@
<style is="custom-style" include="signin-dialog-shared">
.details {
line-height: 20px;
- margin-bottom: 8px;
margin-left: -8px;
Dan Beam 2017/01/11 18:56:02 should this be -webkit-margin-start: -8px; so it f
msarda 2017/01/12 16:11:07 Done.
- padding: 0 24px;
+ padding: 8px 24px 0 24px;
+ }
Dan Beam 2017/01/11 18:56:02 this could be expressed more shortly as padding:
msarda 2017/01/12 16:11:07 Done.
+
+ .container {
+ /* The sign-in confirmation dialog uses a width that is larger than
+ the other sign-in dialogs to fit cases when the user has an email name
+ that is very large*/
Dan Beam 2017/01/11 18:56:02 /* CSS comments * are typically formatted * like
msarda 2017/01/12 16:11:07 Done.
+ width: 512px;
+ }
+
+ .radio-button-title-container {
+ line-height: 20px;
+ }
+
+ .top-title-bar {
+ color: #333;
+
+ /* The signin email confirmation dialog needs to support cases when the
+ title extends multiple lines. In that case, the height of the title
+ bar is equal to padding + height of the text (which is equal to
+ 2*16px + nb_lines * 22px).
+ */
+ line-height: 22px;
+ padding: 16px 24px;
+ height: auto;
}
#closeButton {
@@ -41,10 +64,16 @@
<paper-radio-group selected="createNewUser">
<paper-radio-button id="createNewUserRadioButton"
name="createNewUser">
- $i18n{signinEmailConfirmationCreateProfileButtonTitle}
+ <div class="radio-button-title-container"
+ id="createNewUserRadioButtonTitle">
+ $i18n{signinEmailConfirmationCreateProfileButtonTitle}
+ </div>
</paper-radio-button>
<paper-radio-button id="startSyncRadioButton" name="startSync">
- $i18n{signinEmailConfirmationStartSyncButtonTitle}
+ <div class="radio-button-title-container"
+ id="startSyncRadioButtonTitle">
+ $i18n{signinEmailConfirmationStartSyncButtonTitle}
+ </div>
</paper-radio-button>
</paper-radio-group>
</div>

Powered by Google App Engine
This is Rietveld 408576698