Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3255)

Unified Diff: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js

Issue 2625663003: Layout nits for the signin email confirmation dialog. (Closed)
Patch Set: Remove unnecessary margin Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js
diff --git a/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js b/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js
index ef2ebbc8018e3d40bda7a594785f5192db20cd6b..0a78974153765bdfabdd3f713b27a9fde5927f43 100644
--- a/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js
+++ b/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js
@@ -11,9 +11,9 @@ cr.define('signin.emailConfirmation', function() {
var newEmail = args.newEmail;
$('dialogTitle').textContent = loadTimeData.getStringF(
'signinEmailConfirmationTitle', lastEmail);
- $('createNewUserRadioButton').innerHTML = loadTimeData.getStringF(
+ $('createNewUserRadioButtonTitle').innerHTML = loadTimeData.getStringF(
Dan Beam 2017/01/11 18:56:02 could this be .textContent instead?
msarda 2017/01/12 16:11:07 Not, this cannot be .textContent as this contains
Dan Beam 2017/01/12 18:32:58 please use I18nBehavior and i18n() or i18nAdvanced
msarda 2017/01/13 09:54:16 Done.
'signinEmailConfirmationCreateProfileButtonTitle', newEmail);
- $('startSyncRadioButton').innerHTML = loadTimeData.getStringF(
+ $('startSyncRadioButtonTitle').innerHTML = loadTimeData.getStringF(
'signinEmailConfirmationStartSyncButtonTitle', newEmail);
document.addEventListener('keydown', onKeyDown);

Powered by Google App Engine
This is Rietveld 408576698