chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js - Issue 2625663003: Layout nits for the signin email confirmation dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js

Issue 2625663003: Layout nits for the signin email confirmation dialog. (Closed)

Patch Set: Nits and use I18nBehavior.i18n Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html ('k') | chrome/browser/resources/signin/signin_shared_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js

diff --git a/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js b/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js

index ef2ebbc8018e3d40bda7a594785f5192db20cd6b..f4f41643e98f503b62d626471bf682996fbda454 100644

--- a/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js

+++ b/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js

@@ -11,9 +11,9 @@ cr.define('signin.emailConfirmation', function() {

var newEmail = args.newEmail;

$('dialogTitle').textContent = loadTimeData.getStringF(

'signinEmailConfirmationTitle', lastEmail);

- $('createNewUserRadioButton').innerHTML = loadTimeData.getStringF(

+ $('createNewUserRadioButtonTitle').innerHTML = I18nBehavior.i18n(

'signinEmailConfirmationCreateProfileButtonTitle', newEmail);

- $('startSyncRadioButton').innerHTML = loadTimeData.getStringF(

+ $('startSyncRadioButtonTitle').innerHTML = I18nBehavior.i18n(

'signinEmailConfirmationStartSyncButtonTitle', newEmail);

document.addEventListener('keydown', onKeyDown);