chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html - Issue 2625663003: Layout nits for the signin email confirmation dialog.

Unified Diff: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html

Issue 2625663003: Layout nits for the signin email confirmation dialog. (Closed)

Patch Set: Nits and use I18nBehavior.i18n Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html

diff --git a/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html b/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html

index c81130284be54ce4cdfb5aa0215e3d92b69421c8..159ab72f4575b27b4c0922607b0ec875217993cf 100644

--- a/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html

+++ b/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html

@@ -2,6 +2,7 @@

<head>

+ <link rel="import" href="chrome://resources/html/i18n_behavior.html">

@@ -13,11 +14,33 @@

+ .container {

+ /* The sign-in confirmation dialog uses a width that is larger than

+ * the other sign-in dialogs to fit cases when the user has an email

+ * name that is very large. */

+ width: 512px;

+ }

.details {

+ -webkit-margin-start: -8px;

+ line-height: 20px;

+ padding: 8px 24px 0;

+ }

+ .radio-button-title-container {

line-height: 20px;

- margin-bottom: 8px;

- margin-left: -8px;

- padding: 0 24px;

+ }

+ .top-title-bar {

+ color: #333;

+ height: auto;

+ /* The signin email confirmation dialog needs to support cases when the

+ * title extends multiple lines. In that case, the height of the title

+ * bar is equal to padding + height of the text (which is equal to

+ * 2*16px + nb_lines * 22px). */

+ line-height: 22px;

+ padding: 16px 24px;

}

#closeButton {

@@ -41,10 +64,16 @@

<paper-radio-group selected="createNewUser">

<paper-radio-button id="createNewUserRadioButton"

name="createNewUser">

- $i18n{signinEmailConfirmationCreateProfileButtonTitle}

+ <div class="radio-button-title-container"

+ id="createNewUserRadioButtonTitle">

+ $i18n{signinEmailConfirmationCreateProfileButtonTitle}

+ </div>

</paper-radio-button>

<paper-radio-button id="startSyncRadioButton" name="startSync">

- $i18n{signinEmailConfirmationStartSyncButtonTitle}

+ <div class="radio-button-title-container"

+ id="startSyncRadioButtonTitle">

+ $i18n{signinEmailConfirmationStartSyncButtonTitle}

+ </div>

</paper-radio-button>

</paper-radio-group>

</div>

« no previous file with comments | « no previous file | chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js » ('j') | no next file with comments »