|
|
Created:
3 years, 11 months ago by tyoshino (SeeGerritForStatus) Modified:
3 years, 11 months ago Reviewers:
yhirano CC:
chromium-reviews, blink-reviews, haraken Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake the FetchManager constructor private
R=yhirano@chromium.org
BUG=none
Review-Url: https://codereview.chromium.org/2625573003
Cr-Commit-Position: refs/heads/master@{#442867}
Committed: https://chromium.googlesource.com/chromium/src/+/facc326c5c6b19ab36e529ed8e2713c794901fe4
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Description was changed from ========== Make the FetchManager constructor protected BUG=none ========== to ========== Make the FetchManager constructor protected BUG=none ==========
tyoshino@chromium.org changed reviewers: + yhirano@chromium.org
Description was changed from ========== Make the FetchManager constructor protected BUG=none ========== to ========== Make the FetchManager constructor private BUG=none ==========
lgtm
Description was changed from ========== Make the FetchManager constructor private BUG=none ========== to ========== Make the FetchManager constructor private R=yhirano@chromium.org BUG=none ==========
The CQ bit was checked by tyoshino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tyoshino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1484127876281610, "parent_rev": "6ab8be2474cd5017e22a4027019546a145474207", "commit_rev": "facc326c5c6b19ab36e529ed8e2713c794901fe4"}
Message was sent while issue was closed.
Description was changed from ========== Make the FetchManager constructor private R=yhirano@chromium.org BUG=none ========== to ========== Make the FetchManager constructor private R=yhirano@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2625573003 Cr-Commit-Position: refs/heads/master@{#442867} Committed: https://chromium.googlesource.com/chromium/src/+/facc326c5c6b19ab36e529ed8e27... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/facc326c5c6b19ab36e529ed8e27... |