Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2625573003: Make the FetchManager constructor private (Closed)

Created:
3 years, 11 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 11 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the FetchManager constructor private R=yhirano@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2625573003 Cr-Commit-Position: refs/heads/master@{#442867} Committed: https://chromium.googlesource.com/chromium/src/+/facc326c5c6b19ab36e529ed8e2713c794901fe4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/modules/fetch/FetchManager.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
tyoshino (SeeGerritForStatus)
3 years, 11 months ago (2017-01-11 07:29:50 UTC) #8
yhirano
lgtm
3 years, 11 months ago (2017-01-11 08:09:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625573003/1
3 years, 11 months ago (2017-01-11 08:14:56 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97925)
3 years, 11 months ago (2017-01-11 09:21:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625573003/1
3 years, 11 months ago (2017-01-11 09:45:10 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 11:05:49 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/facc326c5c6b19ab36e529ed8e27...

Powered by Google App Engine
This is Rietveld 408576698