Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2625513002: [M56] Turn off video overlay on android for rotated video. (Closed)

Created:
3 years, 11 months ago by liberato (no reviews please)
Modified:
3 years, 11 months ago
Reviewers:
DaleCurtis
CC:
apacible+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[M56] Turn off video overlay on android for rotated video. Merge to M56 of https://codereview.chromium.org/2611783002 . Don't enable SurfaceView overlays for video if the metadata says that the video is rotated, since SurfaceView won't rotate it. Also switch out of overlay mode if the metadata changes. This also changes the 'exit full screen' logic to check if an overlay is in use to decide if it needs to turn them off. BUG=669081 TBR=dalecurtis@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2625513002 Cr-Commit-Position: refs/branch-heads/2924@{#719} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/04159658b3aba4c732bcd9332df6f98c40bc7f21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M media/blink/webmediaplayer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 3 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
liberato (no reviews please)
cherry-pick didn't apply cleanly. works locally. but another look before merging back is appreciated. thanks ...
3 years, 11 months ago (2017-01-09 21:05:43 UTC) #1
DaleCurtis
lgtm
3 years, 11 months ago (2017-01-10 19:11:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625513002/1
3 years, 11 months ago (2017-01-10 20:00:25 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 20:02:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04159658b3aba4c732bcd9332df6...

Powered by Google App Engine
This is Rietveld 408576698