Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2625493002: Issue 28068. Implement diagnostics domain for the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 3 chunks +18 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 2 chunks +8 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-09 19:16:04 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-09 19:34:22 UTC) #2
scheglov
3 years, 11 months ago (2017-01-09 20:07:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a9c5ac1eceb7386b5f96ddef4377eb98fbe3c8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698