Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: pkg/analysis_server/test/domain_diagnostic_test.dart

Issue 2625493002: Issue 28068. Implement diagnostics domain for the new analysis driver. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/domain_diagnostic.dart ('k') | pkg/analyzer/lib/src/dart/analysis/driver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_diagnostic_test.dart
diff --git a/pkg/analysis_server/test/domain_diagnostic_test.dart b/pkg/analysis_server/test/domain_diagnostic_test.dart
index a7608a6b837d855130603dc54d022c55b95bc953..fcaf75532475452fac77f871995bc0edf233356b 100644
--- a/pkg/analysis_server/test/domain_diagnostic_test.dart
+++ b/pkg/analysis_server/test/domain_diagnostic_test.dart
@@ -46,8 +46,14 @@ class DiagnosticDomainTest extends AbstractAnalysisTest {
expect(context.name, '/project');
expect(context.explicitFileCount, 1); /* test.dart */
- // dart:core dart:async dart:math dart:_internal
- expect(context.implicitFileCount, 4);
+ if (enableNewAnalysisDriver) {
+ // dart:core (although it should not be here)
+ expect(context.implicitFileCount, 1);
+ } else {
+ // dart:core dart:async dart:math dart:_internal
+ expect(context.implicitFileCount, 4);
+ }
+
expect(context.workItemQueueLength, isNotNull);
}
@@ -67,16 +73,4 @@ class DiagnosticDomainTest_Driver extends DiagnosticDomainTest {
generateSummaryFiles = true;
super.setUp();
}
-
- @failingTest
- @override
- test_getDiagnostics() {
- return super.test_getDiagnostics();
- }
-
- @failingTest
- @override
- test_getDiagnostics_noRoot() {
- return super.test_getDiagnostics_noRoot();
- }
}
« no previous file with comments | « pkg/analysis_server/lib/src/domain_diagnostic.dart ('k') | pkg/analyzer/lib/src/dart/analysis/driver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698