Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2625413003: [turbofan] Fix deopt loop due to forgetting maps on Merge. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deopt loop due to forgetting maps on Merge. When we merge two NotFound access infos, we currently forgot to include all the maps into the final PropertyAccessInfo, which results in a deopt loop. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2625413003 Cr-Commit-Position: refs/heads/master@{#42332} Committed: https://chromium.googlesource.com/v8/v8/+/cb80ef310f8310f2bfa3cc094ed228c783dca39f

Patch Set 1 #

Patch Set 2 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/compiler/access-info.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-13 12:23:21 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-13 13:50:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625413003/20001
3 years, 11 months ago (2017-01-13 13:50:33 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 14:17:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/cb80ef310f8310f2bfa3cc094ed228c783d...

Powered by Google App Engine
This is Rietveld 408576698