Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2625363003: [Extensions Bindings] Update APIRequestHandlerUnittest to APIBindingTest (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Update APIRequestHandlerUnittest to APIBindingTest Make APIRequestHandlerUnittest derive APIBindingTest, clean up a few of the instantions, and remove some unneeded includes. BUG=653596 Review-Url: https://codereview.chromium.org/2625363003 Cr-Commit-Position: refs/heads/master@{#443459} Committed: https://chromium.googlesource.com/chromium/src/+/950c72c0aa7e425979082161e0100e774379f9f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -26 lines) Patch
M extensions/renderer/api_request_handler_unittest.cc View 8 chunks +15 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Devlin
simple cleanup; take a look when you have time. :) jbroman@ fyi
3 years, 11 months ago (2017-01-12 23:52:14 UTC) #2
lazyboy
lgtm
3 years, 11 months ago (2017-01-13 00:03:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625363003/1
3 years, 11 months ago (2017-01-13 00:06:06 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:01:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/950c72c0aa7e425979082161e010...

Powered by Google App Engine
This is Rietveld 408576698