Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 262533009: Revert "Trigger exception debug event for promises at the throw site." (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert "Trigger exception debug event for promises at the throw site." This reverts r21092. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -216 lines) Patch
M include/v8-debug.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/debug.h View 3 chunks +3 lines, -14 lines 0 comments Download
M src/debug.cc View 7 chunks +9 lines, -55 lines 0 comments Download
M src/debug-debugger.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mirror-debugger.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/promise.js View 4 chunks +21 lines, -13 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +6 lines, -15 lines 0 comments Download
M test/mjsunit/es6/debug-promises-caught-all.js View 2 chunks +3 lines, -2 lines 0 comments Download
D test/mjsunit/es6/debug-promises-caught-late.js View 1 chunk +0 lines, -38 lines 0 comments Download
M test/mjsunit/es6/debug-promises-caught-uncaught.js View 2 chunks +3 lines, -1 line 0 comments Download
D test/mjsunit/es6/debug-promises-throw-in-constructor.js View 1 chunk +0 lines, -46 lines 0 comments Download
M test/mjsunit/es6/debug-promises-throw-in-reject.js View 3 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/es6/debug-promises-uncaught-all.js View 2 chunks +15 lines, -8 lines 0 comments Download
M test/mjsunit/es6/debug-promises-uncaught-uncaught.js View 3 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/es6/debug-promises-undefined-reject.js View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 7 months ago (2014-04-30 14:50:31 UTC) #1
Igor Sheludko
Rubberstamp lgtm
6 years, 7 months ago (2014-04-30 14:51:19 UTC) #2
Yang
6 years, 7 months ago (2014-04-30 14:52:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21094 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698