Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: test/mjsunit/es6/debug-promises-caught-all.js

Issue 262533009: Revert "Trigger exception debug event for promises at the throw site." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/es6/debug-promises-caught-late.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/debug-promises-caught-all.js
diff --git a/test/mjsunit/es6/debug-promises-caught-all.js b/test/mjsunit/es6/debug-promises-caught-all.js
index 5189373e1849e1850e4449355002b684d5e3214e..53369e3efc8b6035bede19154e79782e01172369 100644
--- a/test/mjsunit/es6/debug-promises-caught-all.js
+++ b/test/mjsunit/es6/debug-promises-caught-all.js
@@ -6,7 +6,8 @@
// Test debug events when we listen to all exceptions and
// there is a catch handler for the exception thrown in a Promise.
-// We expect a normal Exception debug event to be triggered.
+// Expectation:
+// - only the normal Exception debug event is triggered.
Debug = debug.Debug;
@@ -34,10 +35,10 @@ function listener(event, exec_state, event_data, data) {
// Ignore exceptions during startup in stress runs.
if (step >= 1) return;
assertEquals(["resolve", "end main", "throw"], log);
+ assertTrue(event != Debug.DebugEvent.PendingExceptionInPromise);
if (event == Debug.DebugEvent.Exception) {
assertEquals("caught", event_data.exception().message);
assertEquals(undefined, event_data.promise());
- assertFalse(event_data.uncaught());
step++;
}
} catch (e) {
« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/es6/debug-promises-caught-late.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698