Migrate more vector icons to chrome/.

Migrate more vector icons to chrome/.

- Move and rename the find bar buttons (since they're used beyond just
  the find bar these days).
- Fix VectorIconButton's disabled state.

BUG=626786
Review-Url: https://codereview.chromium.org/2625273002
Cr-Commit-Position: refs/heads/master@{#443275}
Committed: https://chromium.googlesource.com/chromium/src/+/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c

[Evan Stade, 2017-01-12 01:22:29]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-01-12 01:22:56]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2017-01-12 01:22:57]

+sky for review
+anthonyvd as FYI

[commit-bot: I haz the power, 2017-01-12 01:23:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:04:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:04:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2017-01-12 16:21:35]

https://codereview.chromium.org/2625273002/diff/1/chrome/browser/ui/cocoa/fin...
File chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm (right):

https://codereview.chromium.org/2625273002/diff/1/chrome/browser/ui/cocoa/fin...
chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm:138:
NSImageFromImageSkia(gfx::CreateVectorIcon(kFindNext, SK_ColorBLACK));
Shouldn't this and the next be kCaretDown and kCaretUp?

[Evan Stade, 2017-01-12 16:29:42]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-01-12 16:29:47]

https://codereview.chromium.org/2625273002/diff/1/chrome/browser/ui/cocoa/fin...
File chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm (right):

https://codereview.chromium.org/2625273002/diff/1/chrome/browser/ui/cocoa/fin...
chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm:138:
NSImageFromImageSkia(gfx::CreateVectorIcon(kFindNext, SK_ColorBLACK));
On 2017/01/12 16:21:34, sky wrote:
> Shouldn't this and the next be kCaretDown and kCaretUp?

yes. Bit of a brain fart. It's rare that I post a change that doesn't have at
least one patchset labeled "fix mac".

[commit-bot: I haz the power, 2017-01-12 16:30:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-12 16:34:44]

LGTM

[Evan Stade, 2017-01-12 16:44:35]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2017-01-12 16:44:39]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-01-12 16:45:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 17:22:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484239479994520,
"parent_rev": "69056e552cde6e0019daf2a1d84d8e60f5690617", "commit_rev":
"48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c"}

[commit-bot: I haz the power, 2017-01-12 17:24:16]

Description was changed from

==========
Migrate more vector icons to chrome/.

- Move and rename the find bar buttons (since they're used beyond just
  the find bar these days).
- Fix VectorIconButton's disabled state.

BUG=626786
==========

to

==========
Migrate more vector icons to chrome/.

- Move and rename the find bar buttons (since they're used beyond just
  the find bar these days).
- Fix VectorIconButton's disabled state.

BUG=626786

Review-Url: https://codereview.chromium.org/2625273002
Cr-Commit-Position: refs/heads/master@{#443275}
Committed:
https://chromium.googlesource.com/chromium/src/+/48d29c26b53c8f5809b2afaf7d9f...
==========

[commit-bot: I haz the power, 2017-01-12 17:24:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48d29c26b53c8f5809b2afaf7d9f...