Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2625233004: Fix closure comilation error. (Closed)

Created:
3 years, 11 months ago by fukino
Modified:
3 years, 11 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org, Devlin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure comilation error. As a quick fix, I'll revert the change of file_manager_private.js in https://codereview.chromium.org/2580303002/. BUG=none TBR=nya@chromium.org TEST=run third_party/closure_compiler/run_compiler Review-Url: https://codereview.chromium.org/2625233004 Cr-Commit-Position: refs/heads/master@{#443214} Committed: https://chromium.googlesource.com/chromium/src/+/71fc94ca2e7688389d7d7de63ebf67cc3284a30f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -610 lines) Patch
M third_party/closure_compiler/externs/file_manager_private.js View 10 chunks +260 lines, -610 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625233004/1
3 years, 11 months ago (2017-01-12 11:44:14 UTC) #2
Shuhei Takahashi
lgtm Thanks Fukino-san for the prompt fix. I'm wondering why this happened... I dumbly followed ...
3 years, 11 months ago (2017-01-12 12:41:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/71fc94ca2e7688389d7d7de63ebf67cc3284a30f
3 years, 11 months ago (2017-01-12 12:50:09 UTC) #6
fukino
On 2017/01/12 12:41:00, Shuhei Takahashi wrote: > lgtm > > Thanks Fukino-san for the prompt ...
3 years, 11 months ago (2017-01-12 12:54:03 UTC) #7
Dan Beam
3 years, 11 months ago (2017-01-12 20:00:53 UTC) #9
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698