Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2625233002: Add expectations for three layout tests failing on Site Isolation bots. (Closed)

Created:
3 years, 11 months ago by alexmos
Modified:
3 years, 11 months ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add expectations for three layout tests failing on Site Isolation bots. This should hopefully get the bots back to green while individual bugs are being investigated. BUG=680201, 661725, 680249, 680307 NOTRY=true Review-Url: https://codereview.chromium.org/2625233002 Cr-Commit-Position: refs/heads/master@{#443071} Committed: https://chromium.googlesource.com/chromium/src/+/96557bfa11c102628943935e7906cff4b3b04a74

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add virtual/mojo-loading variants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alexmos
Lukasz, can you please take a look? It didn't look like any of these have ...
3 years, 11 months ago (2017-01-11 23:47:41 UTC) #3
Łukasz Anforowicz
LGTM - thanks for taking a look at these failures. https://codereview.chromium.org/2625233002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right): https://codereview.chromium.org/2625233002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process#newcode16 ...
3 years, 11 months ago (2017-01-11 23:52:12 UTC) #4
alexmos
https://codereview.chromium.org/2625233002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right): https://codereview.chromium.org/2625233002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process#newcode178 third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:178: crbug.com/680307 http/tests/security/mixedContent/blob-url-in-iframe.html [ Failure ] On 2017/01/11 23:52:12, Łukasz ...
3 years, 11 months ago (2017-01-11 23:56:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625233002/20001
3 years, 11 months ago (2017-01-12 00:03:08 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:15:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96557bfa11c102628943935e7906...

Powered by Google App Engine
This is Rietveld 408576698