Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: content/renderer/render_process_impl.cc

Issue 2625213003: Rename *FileIO TaskScheduler worker pools to *Blocking. (Closed)
Patch Set: update dates Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_process_impl.h" 5 #include "content/renderer/render_process_impl.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 8
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include <windows.h> 10 #include <windows.h>
(...skipping 27 matching lines...) Expand all
38 #include "v8/include/v8.h" 38 #include "v8/include/v8.h"
39 39
40 #if defined(OS_WIN) 40 #if defined(OS_WIN)
41 #include "base/win/win_util.h" 41 #include "base/win/win_util.h"
42 #endif 42 #endif
43 43
44 namespace { 44 namespace {
45 45
46 enum WorkerPoolType : size_t { 46 enum WorkerPoolType : size_t {
47 BACKGROUND = 0, 47 BACKGROUND = 0,
48 BACKGROUND_FILE_IO, 48 BACKGROUND_BLOCKING,
49 FOREGROUND, 49 FOREGROUND,
50 FOREGROUND_FILE_IO, 50 FOREGROUND_BLOCKING,
51 WORKER_POOL_COUNT // Always last. 51 WORKER_POOL_COUNT // Always last.
52 }; 52 };
53 53
54 const base::Feature kV8_ES2015_TailCalls_Feature { 54 const base::Feature kV8_ES2015_TailCalls_Feature {
55 "V8_ES2015_TailCalls", base::FEATURE_DISABLED_BY_DEFAULT 55 "V8_ES2015_TailCalls", base::FEATURE_DISABLED_BY_DEFAULT
56 }; 56 };
57 57
58 const base::Feature kV8_ES2016_ExplicitTailCalls_Feature{ 58 const base::Feature kV8_ES2016_ExplicitTailCalls_Feature{
59 "V8_ES2016_ExplicitTailCalls", base::FEATURE_DISABLED_BY_DEFAULT}; 59 "V8_ES2016_ExplicitTailCalls", base::FEATURE_DISABLED_BY_DEFAULT};
60 60
(...skipping 20 matching lines...) Expand all
81 v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag)); 81 v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag));
82 } 82 }
83 } 83 }
84 84
85 std::vector<base::SchedulerWorkerPoolParams> 85 std::vector<base::SchedulerWorkerPoolParams>
86 GetDefaultSchedulerWorkerPoolParams() { 86 GetDefaultSchedulerWorkerPoolParams() {
87 using StandbyThreadPolicy = 87 using StandbyThreadPolicy =
88 base::SchedulerWorkerPoolParams::StandbyThreadPolicy; 88 base::SchedulerWorkerPoolParams::StandbyThreadPolicy;
89 using ThreadPriority = base::ThreadPriority; 89 using ThreadPriority = base::ThreadPriority;
90 constexpr int kMaxNumThreadsInBackgroundPool = 1; 90 constexpr int kMaxNumThreadsInBackgroundPool = 1;
91 constexpr int kMaxNumThreadsInBackgroundFileIOPool = 1; 91 constexpr int kMaxNumThreadsInBackgroundBlockingPool = 1;
92 constexpr int kMaxNumThreadsInForegroundPoolLowerBound = 2; 92 constexpr int kMaxNumThreadsInForegroundPoolLowerBound = 2;
93 constexpr int kMaxNumThreadsInForegroundFileIOPool = 1; 93 constexpr int kMaxNumThreadsInForegroundBlockingPool = 1;
94 constexpr auto kSuggestedReclaimTime = base::TimeDelta::FromSeconds(30); 94 constexpr auto kSuggestedReclaimTime = base::TimeDelta::FromSeconds(30);
95 95
96 std::vector<base::SchedulerWorkerPoolParams> params_vector; 96 std::vector<base::SchedulerWorkerPoolParams> params_vector;
97 params_vector.emplace_back("RendererBackground", ThreadPriority::BACKGROUND, 97 params_vector.emplace_back("RendererBackground", ThreadPriority::BACKGROUND,
98 StandbyThreadPolicy::LAZY, 98 StandbyThreadPolicy::LAZY,
99 kMaxNumThreadsInBackgroundPool, 99 kMaxNumThreadsInBackgroundPool,
100 kSuggestedReclaimTime); 100 kSuggestedReclaimTime);
101 params_vector.emplace_back( 101 params_vector.emplace_back(
102 "RendererBackgroundFileIO", ThreadPriority::BACKGROUND, 102 "RendererBackgroundBlocking", ThreadPriority::BACKGROUND,
103 StandbyThreadPolicy::LAZY, kMaxNumThreadsInBackgroundFileIOPool, 103 StandbyThreadPolicy::LAZY, kMaxNumThreadsInBackgroundBlockingPool,
104 kSuggestedReclaimTime); 104 kSuggestedReclaimTime);
105 params_vector.emplace_back("RendererForeground", ThreadPriority::NORMAL, 105 params_vector.emplace_back("RendererForeground", ThreadPriority::NORMAL,
106 StandbyThreadPolicy::LAZY, 106 StandbyThreadPolicy::LAZY,
107 std::max(kMaxNumThreadsInForegroundPoolLowerBound, 107 std::max(kMaxNumThreadsInForegroundPoolLowerBound,
108 base::SysInfo::NumberOfProcessors()), 108 base::SysInfo::NumberOfProcessors()),
109 kSuggestedReclaimTime); 109 kSuggestedReclaimTime);
110 params_vector.emplace_back("RendererForegroundFileIO", ThreadPriority::NORMAL, 110 params_vector.emplace_back("RendererForegroundBlocking",
111 StandbyThreadPolicy::LAZY, 111 ThreadPriority::NORMAL, StandbyThreadPolicy::LAZY,
112 kMaxNumThreadsInForegroundFileIOPool, 112 kMaxNumThreadsInForegroundBlockingPool,
113 kSuggestedReclaimTime); 113 kSuggestedReclaimTime);
114 DCHECK_EQ(WORKER_POOL_COUNT, params_vector.size()); 114 DCHECK_EQ(WORKER_POOL_COUNT, params_vector.size());
115 return params_vector; 115 return params_vector;
116 } 116 }
117 117
118 // Returns the worker pool index for |traits| defaulting to FOREGROUND or 118 // Returns the worker pool index for |traits| defaulting to FOREGROUND or
119 // FOREGROUND_FILE_IO on any other priorities based off of worker pools defined 119 // FOREGROUND_BLOCKING on any other priorities based off of worker pools defined
120 // in GetDefaultSchedulerWorkerPoolParams(). 120 // in GetDefaultSchedulerWorkerPoolParams().
121 size_t DefaultRendererWorkerPoolIndexForTraits(const base::TaskTraits& traits) { 121 size_t DefaultRendererWorkerPoolIndexForTraits(const base::TaskTraits& traits) {
122 const bool is_background = 122 const bool is_background =
123 traits.priority() == base::TaskPriority::BACKGROUND; 123 traits.priority() == base::TaskPriority::BACKGROUND;
124 if (traits.may_block() || traits.with_base_sync_primitives()) 124 if (traits.may_block() || traits.with_base_sync_primitives())
125 return is_background ? BACKGROUND_FILE_IO : FOREGROUND_FILE_IO; 125 return is_background ? BACKGROUND_BLOCKING : FOREGROUND_BLOCKING;
126 126
127 return is_background ? BACKGROUND : FOREGROUND; 127 return is_background ? BACKGROUND : FOREGROUND;
128 } 128 }
129 129
130 } // namespace 130 } // namespace
131 131
132 namespace content { 132 namespace content {
133 133
134 RenderProcessImpl::RenderProcessImpl( 134 RenderProcessImpl::RenderProcessImpl(
135 const std::vector<base::SchedulerWorkerPoolParams>& worker_pool_params, 135 const std::vector<base::SchedulerWorkerPoolParams>& worker_pool_params,
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 233
234 void RenderProcessImpl::AddBindings(int bindings) { 234 void RenderProcessImpl::AddBindings(int bindings) {
235 enabled_bindings_ |= bindings; 235 enabled_bindings_ |= bindings;
236 } 236 }
237 237
238 int RenderProcessImpl::GetEnabledBindings() const { 238 int RenderProcessImpl::GetEnabledBindings() const {
239 return enabled_bindings_; 239 return enabled_bindings_;
240 } 240 }
241 241
242 } // namespace content 242 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698