Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

Issue 2625093002: [wrapper-tracing] Add heap snapshot generator infrastructure (Closed)
Patch Set: Rebase and fix CHECK Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
index f8008b7d0cc78c95995d603ec6ff365b67ba3cd7..2b96684163c8d228538126947eb833f33b56039f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
@@ -169,6 +169,9 @@ class CORE_EXPORT ScriptWrappableVisitor : public v8::EmbedderHeapTracer,
return &m_headersToUnmark;
}
+ // Immediately cleans up all wrappers if necessary.
+ void performCleanup();
+
protected:
bool pushToMarkingDeque(
void (*traceWrappersCallback)(const WrapperVisitor*, const void*),
@@ -189,7 +192,6 @@ class CORE_EXPORT ScriptWrappableVisitor : public v8::EmbedderHeapTracer,
return true;
}
- private:
// Returns true if wrapper tracing is currently in progress, i.e.,
// TracePrologue has been called, and TraceEpilogue has not yet been called.
bool m_tracingInProgress = false;
@@ -208,9 +210,6 @@ class CORE_EXPORT ScriptWrappableVisitor : public v8::EmbedderHeapTracer,
// avoid cleaning up in the next GC cycle.
bool m_shouldCleanup = false;
- // Immediately cleans up all wrappers.
- void performCleanup();
-
// Schedule an idle task to perform a lazy (incremental) clean up of
// wrappers.
void scheduleIdleLazyCleanup();

Powered by Google App Engine
This is Rietveld 408576698