third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp - Issue 2625093002: [wrapper-tracing] Add heap snapshot generator infrastructure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

Issue 2625093002: [wrapper-tracing] Add heap snapshot generator infrastructure (Closed)

Patch Set: Rebase and fix CHECK Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8GCController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

index 83eaff908273c2b21d79a2bde39995a859a1043f..80d5eb2e04cf31da638501873dba58023a5242b5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

@@ -80,6 +80,7 @@ void ScriptWrappableVisitor::performCleanup() {

if (!m_shouldCleanup)

return;

+ CHECK(!m_tracingInProgress);

for (auto header : m_headersToUnmark) {

// Dead objects residing in the marking deque may become invalid due to

// minor garbage collections and are therefore set to nullptr. We have