Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2625073002: Revert of Internalize strings in-place (Closed)

Created:
3 years, 11 months ago by Jakob Kummerow
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Internalize strings in-place (patchset #17 id:320001 of https://codereview.chromium.org/2549773002/ ) Reason for revert: blocks roll, see: https://codereview.chromium.org/2628733002/ Debug mode runs into an Abort("External string expected, but not found"). Original issue's description: > Internalize strings in-place (reland) > > using newly introduced ThinStrings, which store a pointer to the actual, > internalized string they represent. > > BUG=v8:4520 > > (Previously landed as #42168 / af51befe694f. > > Review-Url: https://codereview.chromium.org/2549773002 > Cr-Commit-Position: refs/heads/master@{#42193} > Committed: https://chromium.googlesource.com/v8/v8/+/4c699e349a4986b28574b3a51e8780e3a3d067b1 TBR=ishell@chromium.org,hpayer@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4520 Review-Url: https://codereview.chromium.org/2625073002 Cr-Commit-Position: refs/heads/master@{#42212} Committed: https://chromium.googlesource.com/v8/v8/+/7ef86f809131b169223b0cfe4a2b93792142da4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -906 lines) Patch
M include/v8.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 6 chunks +9 lines, -17 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/ast/ast-types.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +18 lines, -20 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/code-stub-assembler.cc View 17 chunks +67 lines, -102 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/access-builder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/types.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/elements.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/factory.cc View 5 chunks +20 lines, -54 lines 0 comments Download
M src/heap/heap.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +13 lines, -42 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/heap/scavenger.cc View 4 chunks +0 lines, -27 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/ic/accessor-assembler.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/objects.h View 9 chunks +21 lines, -56 lines 0 comments Download
M src/objects.cc View 13 chunks +22 lines, -102 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +6 lines, -13 lines 0 comments Download
M src/objects-inl.h View 8 chunks +4 lines, -33 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/s390/codegen-s390.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M src/value-serializer.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/x87/codegen-x87.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 3 chunks +57 lines, -37 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D test/mjsunit/thin-strings.js View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jakob Kummerow
Created Revert of Internalize strings in-place
3 years, 11 months ago (2017-01-11 09:59:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625073002/1
3 years, 11 months ago (2017-01-11 09:59:38 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:00:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7ef86f809131b169223b0cfe4a2b9379214...

Powered by Google App Engine
This is Rietveld 408576698