Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2625053006: [debugging] Add %Verify() helper and check verify a HeapObject has a Map. (Closed)

Created:
3 years, 11 months ago by Camillo Bruni
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugging] Add %Verify() helper and check verify a HeapObject has a Map. R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2625053006 Cr-Commit-Position: refs/heads/master@{#42322} Committed: https://chromium.googlesource.com/v8/v8/+/124fbe55ecb3bfdcd9624f4dc28baf77d31fa6b5

Patch Set 1 #

Patch Set 2 : added simple verification in release build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/objects-debug.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Camillo Bruni
PTAL
3 years, 11 months ago (2017-01-12 15:59:31 UTC) #2
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-12 16:01:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625053006/20001
3 years, 11 months ago (2017-01-13 12:02:02 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 12:05:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/124fbe55ecb3bfdcd9624f4dc28baf77d31...

Powered by Google App Engine
This is Rietveld 408576698