Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2625053002: Remove redefinitions of ExceptionCode. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, tzik, sof, eae+blinkwatch, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+fileapi, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redefinitions of ExceptionCode. R=haraken BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2625053002 Cr-Commit-Position: refs/heads/master@{#442878} Committed: https://chromium.googlesource.com/chromium/src/+/15f17c04d930aa9499fa0b323fa6fd9bc1c7edbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M third_party/WebKit/Source/core/dom/DOMException.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/ClassList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageErrorCallback.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-11 10:22:04 UTC) #5
haraken
LGTM
3 years, 11 months ago (2017-01-11 11:09:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625053002/1
3 years, 11 months ago (2017-01-11 12:05:15 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 12:09:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15f17c04d930aa9499fa0b323fa6...

Powered by Google App Engine
This is Rietveld 408576698