Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2625043002: Use a new Supplement constructor in ScreenOrientationController (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, nessy, mlamouri+watch-screen-orientation_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, haraken, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a new Supplement constructor in ScreenOrientationController We're deprecating the default constructor of Supplement. This CL also moves GarbageCollectedFinalized up to ScreenOrientationController. BUG=610176 Review-Url: https://codereview.chromium.org/2625043002 Cr-Commit-Position: refs/heads/master@{#442892} Committed: https://chromium.googlesource.com/chromium/src/+/4f175c09b006c9fb9a92a6c769b49e4b97a24889

Patch Set 1 #

Patch Set 2 : temp #

Messages

Total messages: 16 (8 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-11 09:02:25 UTC) #2
sof
lgtm
3 years, 11 months ago (2017-01-11 09:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625043002/20001
3 years, 11 months ago (2017-01-11 09:18:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97970)
3 years, 11 months ago (2017-01-11 10:27:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625043002/20001
3 years, 11 months ago (2017-01-11 11:09:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/98004)
3 years, 11 months ago (2017-01-11 12:32:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625043002/20001
3 years, 11 months ago (2017-01-11 12:35:32 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 13:50:42 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f175c09b006c9fb9a92a6c769b4...

Powered by Google App Engine
This is Rietveld 408576698