Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 2625013002: PPC: Enable P9 and implement mod[s|u][d|w] instr (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Enable P9 and implement mod[s|u][d|w] instr Enabled support for Power9 hardware and implemented P9 modulo instruction. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, jochen@chromium.org BUG= LOG=n Review-Url: https://codereview.chromium.org/2625013002 Cr-Commit-Position: refs/heads/master@{#42341} Committed: https://chromium.googlesource.com/v8/v8/+/8af80a0af97b7d76a81f83b304ac276f8980e533

Patch Set 1 #

Patch Set 2 : fixed minor errors in assembler #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -15 lines) Patch
M src/base/cpu.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/base/cpu.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +20 lines, -4 lines 0 comments Download
M src/globals.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 2 4 chunks +19 lines, -0 lines 0 comments Download
M src/ppc/constants-ppc.h View 1 2 2 chunks +15 lines, -10 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 2 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
JaideepBajwa
3 years, 11 months ago (2017-01-11 16:23:09 UTC) #1
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-12 23:58:30 UTC) #5
john.yan
lgtm
3 years, 11 months ago (2017-01-13 04:56:44 UTC) #6
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-13 08:42:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625013002/20001
3 years, 11 months ago (2017-01-13 19:32:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/30838) v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-13 19:33:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625013002/40001
3 years, 11 months ago (2017-01-13 20:44:12 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 20:46:40 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/8af80a0af97b7d76a81f83b304ac276f898...

Powered by Google App Engine
This is Rietveld 408576698