Remove default-page favicon for interstitials

Remove default-page favicon for interstitials

This CL removes default favicon from interstitial pages. The check to
do that needs to be done before checking the navigation entry, since
interstitial navigations don't commit until the user proceeds through
the interstitial.

BUG=675616
Review-Url: https://codereview.chromium.org/2624983002
Cr-Commit-Position: refs/heads/master@{#444957}
Committed: https://chromium.googlesource.com/chromium/src/+/789e376399c0241ec76917af86c0b216791b6075

[meacer, 2017-01-11 02:37:29]

meacer@chromium.org changed reviewers:
+ stevenjb@chromium.org

[meacer, 2017-01-11 02:37:30]

stevenjb: Can you PTAL? Thanks.

[stevenjb, 2017-01-11 17:22:50]

owner rs lgtm, but please have sdefresne@ or spqchan@ take a look since they
authored this code.

[meacer, 2017-01-11 18:31:31]

meacer@chromium.org changed reviewers:
+ sdefresne@chromium.org

[meacer, 2017-01-11 18:31:32]

Thanks, sdefresne, can you please take a look too?

[sdefresne, 2017-01-11 18:47:43]

lgtm

[meacer, 2017-01-11 19:54:47]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:55:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:12:16]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[meacer, 2017-01-20 01:35:27]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2017-01-20 01:36:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 02:38:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484876127031410,
"parent_rev": "464e47a82e253d08a7c7236fcf5cb5ec5bf8660b", "commit_rev":
"789e376399c0241ec76917af86c0b216791b6075"}

[commit-bot: I haz the power, 2017-01-20 02:39:13]

Description was changed from

==========
Remove default-page favicon for interstitials

This CL removes default favicon from interstitial pages. The check to
do that needs to be done before checking the navigation entry, since
interstitial navigations don't commit until the user proceeds through
the interstitial.

BUG=675616
==========

to

==========
Remove default-page favicon for interstitials

This CL removes default favicon from interstitial pages. The check to
do that needs to be done before checking the navigation entry, since
interstitial navigations don't commit until the user proceeds through
the interstitial.

BUG=675616

Review-Url: https://codereview.chromium.org/2624983002
Cr-Commit-Position: refs/heads/master@{#444957}
Committed:
https://chromium.googlesource.com/chromium/src/+/789e376399c0241ec76917af86c0...
==========

[commit-bot: I haz the power, 2017-01-20 02:39:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/789e376399c0241ec76917af86c0...