Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2624973003: [heap] Add API function for checking if the heap limit was increased (Closed)

Created:
3 years, 11 months ago by ulan
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add API function for checking if the heap limit was increased for debugging. This function is needed to pass increased heap limit from the main DevTools isolate to the worker isolates it spawns. BUG=chromium:675911 Review-Url: https://codereview.chromium.org/2624973003 Cr-Commit-Position: refs/heads/master@{#42228} Committed: https://chromium.googlesource.com/v8/v8/+/18104fac86ed56ab21843e3e628f33aab92b1c4a

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M include/v8.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +11 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ulan
ptal
3 years, 11 months ago (2017-01-11 09:41:54 UTC) #2
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/2624973003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2624973003/diff/1/include/v8.h#newcode7078 include/v8.h:7078: * Returns true iff the heap limit was ...
3 years, 11 months ago (2017-01-11 12:42:30 UTC) #3
ulan
https://codereview.chromium.org/2624973003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2624973003/diff/1/include/v8.h#newcode7078 include/v8.h:7078: * Returns true iff the heap limit was increased ...
3 years, 11 months ago (2017-01-11 13:03:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624973003/20001
3 years, 11 months ago (2017-01-11 13:03:28 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 13:46:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/18104fac86ed56ab21843e3e628f33aab92...

Powered by Google App Engine
This is Rietveld 408576698