ios/chrome/browser/ui/history/history_service_facade.h - Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/history/history_service_facade.h

Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC. (Closed)

Patch Set: Removes the rest of weak and scoped nsobjects. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/history/history_service_facade.h

diff --git a/ios/chrome/browser/ui/history/history_service_facade.h b/ios/chrome/browser/ui/history/history_service_facade.h

index a6580941a629dde53d7ef31e532c16b56edc79ff..cb0377860f8a74f45a5fd371915d6b286c2bc687 100644

--- a/ios/chrome/browser/ui/history/history_service_facade.h

+++ b/ios/chrome/browser/ui/history/history_service_facade.h

@@ -8,7 +8,6 @@

#include <memory>

#include <string>

-#include "base/ios/weak_nsobject.h"

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "base/scoped_observer.h"

@@ -165,7 +164,7 @@ class HistoryServiceFacade : public history::HistoryServiceObserver {

ios::ChromeBrowserState* browser_state_; // weak

// Delegate for HistoryServiceFacade. Serves as client for HistoryService.

- base::WeakNSProtocol<id<HistoryServiceFacadeDelegate>> delegate_;

+ __weak id<HistoryServiceFacadeDelegate> delegate_;

base::WeakPtrFactory<HistoryServiceFacade> weak_factory_;