Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: ios/chrome/browser/ui/history/history_service_facade.mm

Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC. (Closed)
Patch Set: Removes the rest of weak and scoped nsobjects. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/history/history_service_facade.mm
diff --git a/ios/chrome/browser/ui/history/history_service_facade.mm b/ios/chrome/browser/ui/history/history_service_facade.mm
index caea37d78662c536d2a16a022ec1f0de45fc2868..26d0251375e0f056bf6c594ed7e3b80bd02fa1e9 100644
--- a/ios/chrome/browser/ui/history/history_service_facade.mm
+++ b/ios/chrome/browser/ui/history/history_service_facade.mm
@@ -37,6 +37,10 @@
#include "ios/chrome/browser/ui/history/history_service_facade_delegate.h"
#include "ios/chrome/browser/ui/history/history_util.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
// The amount of time to wait for a response from the WebHistoryService.
static const int kWebHistoryTimeoutSeconds = 3;
@@ -128,7 +132,7 @@ HistoryServiceFacade::HistoryServiceFacade(
HistoryServiceFacade::~HistoryServiceFacade() {
query_task_tracker_.TryCancelAll();
web_history_request_.reset();
- delegate_.reset();
+ delegate_ = nil;
}
void HistoryServiceFacade::QueryHistory(const base::string16& search_text,

Powered by Google App Engine
This is Rietveld 408576698