Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ios/chrome/browser/ui/history/BUILD.gn

Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC. (Closed)
Patch Set: Removes the rest of weak and scoped nsobjects. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/history/clear_browsing_bar.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/history/BUILD.gn
diff --git a/ios/chrome/browser/ui/history/BUILD.gn b/ios/chrome/browser/ui/history/BUILD.gn
index 25c07624c76016879a7e54af4d8aa2f26c74ec84..57f2f8b65bd7e24a67af2337585fb66bbacdf541 100644
--- a/ios/chrome/browser/ui/history/BUILD.gn
+++ b/ios/chrome/browser/ui/history/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
source_set("history") {
+ configs += [ "//build/config/compiler:enable_arc" ]
sources = [
"clear_browsing_bar.h",
"clear_browsing_bar.mm",
@@ -93,12 +94,10 @@ source_set("unit_tests") {
testonly = true
sources = [
"favicon_view_provider_unittest.mm",
- "history_collection_view_controller_unittest.mm",
"history_entries_status_item_unittest.mm",
"history_entry_inserter_unittest.mm",
"history_entry_item_unittest.mm",
"history_search_view_controller_unittest.mm",
- "history_service_facade_unittest.mm",
"history_util_unittest.mm",
"tab_history_popup_controller_unittest.mm",
]
@@ -133,10 +132,59 @@ source_set("unit_tests") {
"//ui/gfx",
"//url",
]
+
+ public_deps = [
+ ":unit_tests_arc",
+ ]
+ allow_circular_includes_from = [ ":unit_tests_arc" ]
+}
+
+source_set("unit_tests_arc") {
+ testonly = true
+ configs += [ "//build/config/compiler:enable_arc" ]
+
+ sources = [
+ "history_collection_view_controller_unittest.mm",
+ "history_service_facade_unittest.mm",
+ ]
+ deps = [
+ ":history",
+ ":resources_unit_tests",
+ "//base",
+ "//base/test:test_support",
+ "//components/favicon/core",
+ "//components/favicon_base",
+ "//components/history/core/browser",
+ "//components/keyed_service/core",
+ "//components/sessions",
+ "//components/strings",
+ "//ios/chrome/app/strings",
+ "//ios/chrome/browser",
+ "//ios/chrome/browser/browser_state:test_support",
+ "//ios/chrome/browser/history",
+ "//ios/chrome/browser/signin",
+ "//ios/chrome/browser/signin:test_support",
+ "//ios/chrome/browser/ui",
+ "//ios/chrome/browser/ui/collection_view",
+ "//ios/chrome/browser/ui/util",
+ "//ios/chrome/common",
+ "//ios/chrome/test:test_support",
+ "//ios/web",
+ "//ios/web:test_support",
+ "//skia",
+ "//testing/gtest",
+ "//third_party/ocmock",
+ "//ui/base",
+ "//ui/gfx",
+ "//url",
+ ]
}
bundle_data("resources_unit_tests") {
- visibility = [ ":unit_tests" ]
+ visibility = [
+ ":unit_tests",
+ ":unit_tests_arc",
+ ]
testonly = true
sources = [
"//ios/chrome/test/data/favicon/test_favicon.png",
« no previous file with comments | « no previous file | ios/chrome/browser/ui/history/clear_browsing_bar.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698