Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: ios/chrome/browser/ui/history/BUILD.gn

Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC. (Closed)
Patch Set: Removes the rest of weak and scoped nsobjects. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/history/clear_browsing_bar.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("history") { 5 source_set("history") {
6 configs += [ "//build/config/compiler:enable_arc" ]
6 sources = [ 7 sources = [
7 "clear_browsing_bar.h", 8 "clear_browsing_bar.h",
8 "clear_browsing_bar.mm", 9 "clear_browsing_bar.mm",
9 "favicon_view.h", 10 "favicon_view.h",
10 "favicon_view.mm", 11 "favicon_view.mm",
11 "favicon_view_provider.h", 12 "favicon_view_provider.h",
12 "favicon_view_provider.mm", 13 "favicon_view_provider.mm",
13 "history_collection_view_controller.h", 14 "history_collection_view_controller.h",
14 "history_collection_view_controller.mm", 15 "history_collection_view_controller.mm",
15 "history_entries_status_item.h", 16 "history_entries_status_item.h",
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 "MobileCoreServices.framework", 87 "MobileCoreServices.framework",
87 "QuartzCore.framework", 88 "QuartzCore.framework",
88 "UIKit.framework", 89 "UIKit.framework",
89 ] 90 ]
90 } 91 }
91 92
92 source_set("unit_tests") { 93 source_set("unit_tests") {
93 testonly = true 94 testonly = true
94 sources = [ 95 sources = [
95 "favicon_view_provider_unittest.mm", 96 "favicon_view_provider_unittest.mm",
96 "history_collection_view_controller_unittest.mm",
97 "history_entries_status_item_unittest.mm", 97 "history_entries_status_item_unittest.mm",
98 "history_entry_inserter_unittest.mm", 98 "history_entry_inserter_unittest.mm",
99 "history_entry_item_unittest.mm", 99 "history_entry_item_unittest.mm",
100 "history_search_view_controller_unittest.mm", 100 "history_search_view_controller_unittest.mm",
101 "history_service_facade_unittest.mm",
102 "history_util_unittest.mm", 101 "history_util_unittest.mm",
103 "tab_history_popup_controller_unittest.mm", 102 "tab_history_popup_controller_unittest.mm",
104 ] 103 ]
105 deps = [ 104 deps = [
106 ":history", 105 ":history",
107 ":resources_unit_tests", 106 ":resources_unit_tests",
108 "//base", 107 "//base",
109 "//base/test:test_support", 108 "//base/test:test_support",
110 "//components/favicon/core", 109 "//components/favicon/core",
111 "//components/favicon_base", 110 "//components/favicon_base",
(...skipping 14 matching lines...) Expand all
126 "//ios/chrome/test:test_support", 125 "//ios/chrome/test:test_support",
127 "//ios/web", 126 "//ios/web",
128 "//ios/web:test_support", 127 "//ios/web:test_support",
129 "//skia", 128 "//skia",
130 "//testing/gtest", 129 "//testing/gtest",
131 "//third_party/ocmock", 130 "//third_party/ocmock",
132 "//ui/base", 131 "//ui/base",
133 "//ui/gfx", 132 "//ui/gfx",
134 "//url", 133 "//url",
135 ] 134 ]
135
136 public_deps = [
137 ":unit_tests_arc",
138 ]
139 allow_circular_includes_from = [ ":unit_tests_arc" ]
140 }
141
142 source_set("unit_tests_arc") {
143 testonly = true
144 configs += [ "//build/config/compiler:enable_arc" ]
145
146 sources = [
147 "history_collection_view_controller_unittest.mm",
148 "history_service_facade_unittest.mm",
149 ]
150 deps = [
151 ":history",
152 ":resources_unit_tests",
153 "//base",
154 "//base/test:test_support",
155 "//components/favicon/core",
156 "//components/favicon_base",
157 "//components/history/core/browser",
158 "//components/keyed_service/core",
159 "//components/sessions",
160 "//components/strings",
161 "//ios/chrome/app/strings",
162 "//ios/chrome/browser",
163 "//ios/chrome/browser/browser_state:test_support",
164 "//ios/chrome/browser/history",
165 "//ios/chrome/browser/signin",
166 "//ios/chrome/browser/signin:test_support",
167 "//ios/chrome/browser/ui",
168 "//ios/chrome/browser/ui/collection_view",
169 "//ios/chrome/browser/ui/util",
170 "//ios/chrome/common",
171 "//ios/chrome/test:test_support",
172 "//ios/web",
173 "//ios/web:test_support",
174 "//skia",
175 "//testing/gtest",
176 "//third_party/ocmock",
177 "//ui/base",
178 "//ui/gfx",
179 "//url",
180 ]
136 } 181 }
137 182
138 bundle_data("resources_unit_tests") { 183 bundle_data("resources_unit_tests") {
139 visibility = [ ":unit_tests" ] 184 visibility = [
185 ":unit_tests",
186 ":unit_tests_arc",
187 ]
140 testonly = true 188 testonly = true
141 sources = [ 189 sources = [
142 "//ios/chrome/test/data/favicon/test_favicon.png", 190 "//ios/chrome/test/data/favicon/test_favicon.png",
143 ] 191 ]
144 outputs = [ 192 outputs = [
145 "{{bundle_resources_dir}}/" + 193 "{{bundle_resources_dir}}/" +
146 "ios/chrome/test/data/favicon/{{source_file_part}}", 194 "ios/chrome/test/data/favicon/{{source_file_part}}",
147 ] 195 ]
148 } 196 }
149 197
(...skipping 24 matching lines...) Expand all
174 "//ios/third_party/earl_grey", 222 "//ios/third_party/earl_grey",
175 "//ios/web:test_support", 223 "//ios/web:test_support",
176 "//net", 224 "//net",
177 "//ui/base", 225 "//ui/base",
178 ] 226 ]
179 libs = [ 227 libs = [
180 "UIKit.framework", 228 "UIKit.framework",
181 "XCTest.framework", 229 "XCTest.framework",
182 ] 230 ]
183 } 231 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/ui/history/clear_browsing_bar.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698