ios/chrome/browser/ui/history/favicon_view_provider.h - Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/history/favicon_view_provider.h

Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC. (Closed)

Patch Set: Reparent and fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/history/favicon_view_provider.h

diff --git a/ios/chrome/browser/ui/history/favicon_view_provider.h b/ios/chrome/browser/ui/history/favicon_view_provider.h

index cba219ac47cae1904aa954ee4e2d287a6ee012a9..5b9563d2764d94b6ca1fd8904aace7daf402a746 100644

--- a/ios/chrome/browser/ui/history/favicon_view_provider.h

+++ b/ios/chrome/browser/ui/history/favicon_view_provider.h

@@ -38,7 +38,7 @@ class GURL;

- (instancetype)init NS_UNAVAILABLE;

// View that displays a favicon or fallback icon.

-@property(nonatomic, readonly) FaviconView* faviconView;

+@property(weak, nonatomic, readonly) FaviconView* faviconView;

lpromero 2017/01/11 18:03:51 Seems backed by a scoped_nsobject, so is it really

stkhapugin 2017/01/12 14:15:43 Done.

@end