ios/chrome/browser/ui/history/favicon_view_provider.h - Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/history/favicon_view_provider.h

Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC. (Closed)

Patch Set: Reparent and fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/ui/history/favicon_view.mm ('k') | ios/chrome/browser/ui/history/favicon_view_provider.mm » ('j') | ios/chrome/browser/ui/history/history_collection_view_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CHROME_BROWSER_UI_HISTORY_FAVICON_VIEW_PROVIDER_H_	5 #ifndef IOS_CHROME_BROWSER_UI_HISTORY_FAVICON_VIEW_PROVIDER_H_

6 #define IOS_CHROME_BROWSER_UI_HISTORY_FAVICON_VIEW_PROVIDER_H_	6 #define IOS_CHROME_BROWSER_UI_HISTORY_FAVICON_VIEW_PROVIDER_H_

7	7

8 #import <UIKit/UIKit.h>	8 #import <UIKit/UIKit.h>

9	9

10 namespace favicon {	10 namespace favicon {

(...skipping 20 matching lines...) Expand all Loading...
31 // favicon has been loaded, and may be nil.	31 // favicon has been loaded, and may be nil.

32 - (instancetype)initWithURL:(const GURL&)URL	32 - (instancetype)initWithURL:(const GURL&)URL

33 faviconSize:(CGFloat)faviconSize	33 faviconSize:(CGFloat)faviconSize

34 minFaviconSize:(CGFloat)minFaviconSize	34 minFaviconSize:(CGFloat)minFaviconSize

35 largeIconService:(favicon::LargeIconService*)largeIconService	35 largeIconService:(favicon::LargeIconService*)largeIconService

36 delegate:(id<FaviconViewProviderDelegate>)delegate	36 delegate:(id<FaviconViewProviderDelegate>)delegate

37 NS_DESIGNATED_INITIALIZER;	37 NS_DESIGNATED_INITIALIZER;

38 - (instancetype)init NS_UNAVAILABLE;	38 - (instancetype)init NS_UNAVAILABLE;

39	39

40 // View that displays a favicon or fallback icon.	40 // View that displays a favicon or fallback icon.

41 @property(nonatomic, readonly) FaviconView* faviconView;	41 @property(weak, nonatomic, readonly) FaviconView* faviconView;
	lpromero 2017/01/11 18:03:51 Seems backed by a scoped_nsobject, so is it really Seems backed by a scoped_nsobject, so is it really weak? stkhapugin 2017/01/12 14:15:43 Done. Show quoted text On 2017/01/11 18:03:51, lpromero wrote: > Seems backed by a scoped_nsobject, so is it really weak? Done.
42	42

43 @end	43 @end

44	44

45 #endif // IOS_CHROME_BROWSER_UI_HISTORY_FAVICON_VIEW_PROVIDER_H_	45 #endif // IOS_CHROME_BROWSER_UI_HISTORY_FAVICON_VIEW_PROVIDER_H_

OLD	NEW