Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2624953002: Set width and height attributes for <img> if image is loaded from srcset (Closed)

Created:
3 years, 11 months ago by jianli
Modified:
3 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink, Dmitry Titov, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set width and height attributes for <img> if image is loaded from srcset For device with high DPR, the image could be loaded from srcset. When the img element is serialized, srcset attribute is skipped. We need to set width and height attributes to retain the original size of the image. BUG=674999 TEST=new tests added Review-Url: https://codereview.chromium.org/2624953002 Cr-Commit-Position: refs/heads/master@{#443058} Committed: https://chromium.googlesource.com/chromium/src/+/a908d62ac9640cc8e9e54521c8ab8133919ef24a

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 2

Patch Set 3 : Fix another typo #

Messages

Total messages: 16 (11 generated)
jianli
3 years, 11 months ago (2017-01-11 02:09:03 UTC) #3
tkent
lgtm https://codereview.chromium.org/2624953002/diff/20001/third_party/WebKit/Source/web/WebFrameSerializer.cpp File third_party/WebKit/Source/web/WebFrameSerializer.cpp (right): https://codereview.chromium.org/2624953002/diff/20001/third_party/WebKit/Source/web/WebFrameSerializer.cpp#newcode217 third_party/WebKit/Source/web/WebFrameSerializer.cpp:217: // has a higher DPR, a different image ...
3 years, 11 months ago (2017-01-11 02:15:32 UTC) #5
jianli
https://codereview.chromium.org/2624953002/diff/20001/third_party/WebKit/Source/web/WebFrameSerializer.cpp File third_party/WebKit/Source/web/WebFrameSerializer.cpp (right): https://codereview.chromium.org/2624953002/diff/20001/third_party/WebKit/Source/web/WebFrameSerializer.cpp#newcode217 third_party/WebKit/Source/web/WebFrameSerializer.cpp:217: // has a higher DPR, a different image from ...
3 years, 11 months ago (2017-01-11 23:12:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624953002/40001
3 years, 11 months ago (2017-01-11 23:13:33 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:49:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a908d62ac9640cc8e9e54521c8ab...

Powered by Google App Engine
This is Rietveld 408576698