Annotation deleted while retriveing it in JS

Annotation deleted while retrieving it in JS

Widgets as returned from GetWidgets() can pop out of existence
unexpectedly, so always return observed pointers.  This extends
the same pattern used elsewhere in the file to all occurrences.

BUG=679642
Review-Url: https://codereview.chromium.org/2624933002
Committed: https://pdfium.googlesource.com/pdfium/+/8fa82794ffc2763e9fa1fc9d401c8e9a14d7c67f

[Tom Sepez, 2017-01-11 01:25:01]

Description was changed from

==========
Annotation deleted while retriveing it in JS

Widgets as returned from GetWidgets() can pop out of existence
unexpectedly, so always return observed pointers.
==========

to

==========
Annotation deleted while retrieving it in JS

Widgets as returned from GetWidgets() can pop out of existence
unexpectedly, so always return observed pointers.  This extends
the same pattern used elsewhere in the file to all occurrences.

BUG=679642
==========

[Tom Sepez, 2017-01-11 01:25:02]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2017-01-11 01:27:56]

Dan, for review.

[Tom Sepez, 2017-01-11 01:30:28]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 01:30:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2017-01-11 13:56:07]

https://codereview.chromium.org/2624933002/diff/40001/fpdfsdk/javascript/Docu...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2624933002/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:515: CPDFSDK_Widget* pWidget =
static_cast<CPDFSDK_Widget*>(pAnnot.Get());
Doesnt' this need a if (pWidget) check in case the observed ptr has gone away?

[Tom Sepez, 2017-01-11 17:11:17]

https://codereview.chromium.org/2624933002/diff/40001/fpdfsdk/javascript/Docu...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2624933002/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:515: CPDFSDK_Widget* pWidget =
static_cast<CPDFSDK_Widget*>(pAnnot.Get());
On 2017/01/11 13:56:07, dsinclair wrote:
> Doesnt' this need a if (pWidget) check in case the observed ptr has gone away?
Ah, I missed one. Done.

[dsinclair, 2017-01-11 17:12:04]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-01-11 17:12:05]

lgtm

[commit-bot: I haz the power, 2017-01-11 17:12:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 17:32:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484154724591130,
"parent_rev": "76a44dea318041f8229d80e70ca3568a435611eb", "commit_rev":
"8fa82794ffc2763e9fa1fc9d401c8e9a14d7c67f"}

[commit-bot: I haz the power, 2017-01-11 17:32:37]

Description was changed from

==========
Annotation deleted while retrieving it in JS

Widgets as returned from GetWidgets() can pop out of existence
unexpectedly, so always return observed pointers.  This extends
the same pattern used elsewhere in the file to all occurrences.

BUG=679642
==========

to

==========
Annotation deleted while retrieving it in JS

Widgets as returned from GetWidgets() can pop out of existence
unexpectedly, so always return observed pointers.  This extends
the same pattern used elsewhere in the file to all occurrences.

BUG=679642

Review-Url: https://codereview.chromium.org/2624933002
Committed:
https://pdfium.googlesource.com/pdfium/+/8fa82794ffc2763e9fa1fc9d401c8e9a14d7...
==========

[commit-bot: I haz the power, 2017-01-11 17:32:38]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/8fa82794ffc2763e9fa1fc9d401c8e9a14d7...