Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/json-stringifier.cc

Issue 2624903003: [runtime] Use PropertyKind/PropertyLocation instead of PropertyType. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/factory.cc ('K') | « src/ic/ic.cc ('k') | src/keys.cc » ('j') | src/lookup.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/json-stringifier.cc
diff --git a/src/json-stringifier.cc b/src/json-stringifier.cc
index 29685c20e22b6eadceca8ea0eba12f668aa7035f..0e5786a84d6e7011cec589536a9e1c80344fd8bf 100644
--- a/src/json-stringifier.cc
+++ b/src/json-stringifier.cc
@@ -534,7 +534,7 @@ JsonStringifier::Result JsonStringifier::SerializeJSObject(
PropertyDetails details = map->instance_descriptors()->GetDetails(i);
if (details.IsDontEnum()) continue;
Handle<Object> property;
- if (details.type() == DATA && *map == js_obj->map()) {
+ if (details.location() == kField && *map == js_obj->map()) {
Jakob Kummerow 2017/01/12 15:40:30 DCHECK_EQ(kData, details.kind());
Igor Sheludko 2017/01/12 15:52:31 Done.
FieldIndex field_index = FieldIndex::ForDescriptor(*map, i);
property = JSObject::FastPropertyAt(js_obj, details.representation(),
field_index);
« src/factory.cc ('K') | « src/ic/ic.cc ('k') | src/keys.cc » ('j') | src/lookup.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698