src/factory.cc - Issue 2624903003: [runtime] Use PropertyKind/PropertyLocation instead of PropertyType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2624903003: [runtime] Use PropertyKind/PropertyLocation instead of PropertyType. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 877b3f7c685750688f890c2c16b0e11a44193bc1..07dc8b5d09d18c097aaf38d4479f684296d178d1 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1770,7 +1770,7 @@ Handle<JSGlobalObject> Factory::NewJSGlobalObject(

for (int i = 0; i < map->NumberOfOwnDescriptors(); i++) {

PropertyDetails details = descs->GetDetails(i);

// Only accessors are expected.

- DCHECK_EQ(ACCESSOR_CONSTANT, details.type());

+ DCHECK_EQ(kAccessor, details.kind());

PropertyDetails d(details.attributes(), ACCESSOR_CONSTANT, i + 1,

Jakob Kummerow 2017/01/12 15:40:30 Doesn't this constructor get updated too?

Igor Sheludko 2017/01/12 15:52:31 Right. I'll update the PropertyDetails constructor

PropertyCellType::kMutable);

Handle<Name> name(descs->GetKey(i));