Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2624863003: [wasm][asm.js] Fix bad asm.js in layout tests. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wasm][asm.js] Fix bad asm.js in layout tests. This causes validation failures breaking the test expectations when the new asm.js -> wasm pipeline is turned on. BUG=v8:4203 R=danno@chromium.org,machenbach@chromium.org,binji@chromium.org Review-Url: https://codereview.chromium.org/2624863003 Cr-Commit-Position: refs/heads/master@{#443047} Committed: https://chromium.googlesource.com/chromium/src/+/57b7617e61e86c83be5819ef826093cafa868f73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/workers/worker-shared-asm-buffer.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
bradn
3 years, 11 months ago (2017-01-11 20:46:07 UTC) #2
bradn
This will fix the v8 fyi bot.
3 years, 11 months ago (2017-01-11 20:47:01 UTC) #7
Michael Achenbach
lgtm rubber stamp
3 years, 11 months ago (2017-01-11 21:00:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624863003/1
3 years, 11 months ago (2017-01-11 21:40:24 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:15:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/57b7617e61e86c83be5819ef8260...

Powered by Google App Engine
This is Rietveld 408576698