Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2624853002: [wasm] JS API tests for `WebAssembly.validate` (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] JS API tests for `WebAssembly.validate` Also ensuring it is validation error to specify more than one memory import. BUG=v8:5824 Review-Url: https://codereview.chromium.org/2624853002 Cr-Commit-Position: refs/heads/master@{#42205} Committed: https://chromium.googlesource.com/v8/v8/+/040f7434cc86ecfbea56f8cdde585d28199af91f

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/wasm/module-decoder.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Mircea Trofin
3 years, 11 months ago (2017-01-10 22:05:41 UTC) #5
bradnelson
lgtm https://codereview.chromium.org/2624853002/diff/1/src/wasm/wasm-module.cc File src/wasm/wasm-module.cc (right): https://codereview.chromium.org/2624853002/diff/1/src/wasm/wasm-module.cc#newcode1661 src/wasm/wasm-module.cc:1661: // validation should have failed if more than ...
3 years, 11 months ago (2017-01-10 22:21:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624853002/20001
3 years, 11 months ago (2017-01-10 23:56:16 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 00:25:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/040f7434cc86ecfbea56f8cdde585d28199...

Powered by Google App Engine
This is Rietveld 408576698