Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2624733004: Fixes bug where NonClientFrameController wasn't registered correctly (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes bug where NonClientFrameController wasn't registered correctly This resulted in ash drawing the title for chrome windows when it shouldn't have. BUG=none TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2624733004 Cr-Commit-Position: refs/heads/master@{#442654} Committed: https://chromium.googlesource.com/chromium/src/+/616f5a726f4c8140d4d6e67d3353488d0a8f8b6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ash/mus/non_client_frame_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 11 months ago (2017-01-10 18:56:46 UTC) #1
Elliot Glaysher
lgtm
3 years, 11 months ago (2017-01-10 18:57:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624733004/1
3 years, 11 months ago (2017-01-10 18:59:47 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:27:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/616f5a726f4c8140d4d6e67d3353...

Powered by Google App Engine
This is Rietveld 408576698