PlzNavigate: fix regression on the FYI bot.

PlzNavigate: fix regression on the FYI bot.

It fixes a regression introduced in crrev.com/2563423004 for the
FYI bot: "Browser Side Navigation Linux".
It happens with Failed navigation within <object data=...>.
m_progressTracker->progressCompleted() lines were removed by the
previous commit and further call to it didn't happen with PlzNavigate.
It leads to a timeout in a few tests.

Tests fixed:
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
- imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

BUG=679675
Review-Url: https://codereview.chromium.org/2624723002
Cr-Commit-Position: refs/heads/master@{#445997}
Committed: https://chromium.googlesource.com/chromium/src/+/68693ab02e29631f4b484299fab89a66c768b01f

[arthursonzogni, 2017-01-10 10:19:25]

The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:19:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[arthursonzogni, 2017-01-10 10:21:03]

Patchset #1 (id:1) has been deleted

[arthursonzogni, 2017-01-10 10:21:29]

The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:21:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 12:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 12:19:33]

Dry run: This issue passed the CQ dry run.

[arthursonzogni, 2017-01-10 12:47:35]

Description was changed from

==========
PlzNavigate: fix regression on the FYI bot.

It fixes a regression introduced in crrev.com/2563423004 for the
FYI bot: "Browser Side Navigation Linux".
It happens with Failed navigation within <object data=...>.
m_progressTracker->progressCompleted() lines were removed by the
previous commit and further call to it didn't happen with PlzNavigate.
It leads to a timeout in a few tests.

Tests fixed:
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
-
imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

Note: the following test is not fixed by this test, so the bot is still
"red".
- virtual/mojo-loading/http/tests/inspector/network/network-datareceived.html

// TODO(arthursonzogni) remove this line once this patch is reviewed,
this bot will fail, but we are interrested only in a few tests.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

BUG=679675
==========

to

==========
PlzNavigate: fix regression on the FYI bot.

It fixes a regression introduced in crrev.com/2563423004 for the
FYI bot: "Browser Side Navigation Linux".
It happens with Failed navigation within <object data=...>.
m_progressTracker->progressCompleted() lines were removed by the
previous commit and further call to it didn't happen with PlzNavigate.
It leads to a timeout in a few tests.

Tests fixed:
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
-
imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

BUG=679675
==========

[arthursonzogni, 2017-01-10 12:48:12]

Description was changed from

==========
PlzNavigate: fix regression on the FYI bot.

It fixes a regression introduced in crrev.com/2563423004 for the
FYI bot: "Browser Side Navigation Linux".
It happens with Failed navigation within <object data=...>.
m_progressTracker->progressCompleted() lines were removed by the
previous commit and further call to it didn't happen with PlzNavigate.
It leads to a timeout in a few tests.

Tests fixed:
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
-
imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

BUG=679675
==========

to

==========
PlzNavigate: fix regression on the FYI bot.

It fixes a regression introduced in crrev.com/2563423004 for the
FYI bot: "Browser Side Navigation Linux".
It happens with Failed navigation within <object data=...>.
m_progressTracker->progressCompleted() lines were removed by the
previous commit and further call to it didn't happen with PlzNavigate.
It leads to a timeout in a few tests.

Tests fixed:
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
-
imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

BUG=679675
==========

[arthursonzogni, 2017-01-10 13:24:25]

arthursonzogni@chromium.org changed reviewers:
+ japhet@chromium.org

[arthursonzogni, 2017-01-10 13:24:25]

Hi Nate,

Please could you take a look at this CL? Thanks!
A regression occurs with one of your patch that didn't interact well with
PlzNavigate :-)
https://codereview.chromium.org/2563423004
https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio...

FYI this are some CLs that have a link with this issue.
https://codereview.chromium.org/2269653002/
https://codereview.chromium.org/2439903003/

https://codereview.chromium.org/2624723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/2624723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1487: checkCompleted();
In https://codereview.chromium.org/2563423004 in FrameLoader::loadFailed()
The lines "m_progressTracker->progressCompleted()" were removed. It's not a
problem because in a non-PlzNavigate world, "checkCompleted()" would have called
it at the end if needed.

However, with PlzNavigate, checkCompleted is prevented to call it when
m_isNavigationHandledByClient is true. It become false again once
stopAllLoader() is called. I don't know if it is expected that stopAllLoader()
is not called?
Whatever happens, it is clear to me that m_isNavigationHandledByClient must be
false here because the browser-side navigation has failed and therefore has
finished.

[Nate Chapin, 2017-01-11 20:30:46]

https://codereview.chromium.org/2624723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/2624723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1464:
m_isNavigationHandledByClient = false;
This isn't obvious to me. A blink-internal navigation failed, why would an
external navigation also fail?

[arthursonzogni, 2017-01-12 12:33:29]

Thanks!
A comment below:

https://codereview.chromium.org/2624723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/2624723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1464:
m_isNavigationHandledByClient = false;
On 2017/01/11 20:30:46, Nate Chapin wrote:
> This isn't obvious to me. A blink-internal navigation failed, why would an
> external navigation also fail?

If an external navigation is in progress, what other kind of load could fail? I
don't know how it works, but I expected that there could be only one thing to
load at a time.

If this is not a good idea to put it here, I can move this statement in the
upper level:
* 0) FrameLoader::loadFailed()
* 1) WebLocalFrameImpl::maybeRenderFallbackContent()
* 2) RenderFrameImpl::OnFailedNavigation()

But I will need to create functions to set m_isNavigationHandledByClient from
outside of the FrameLoader. Do you think to put this line of code in 1) is okay?

Note: In the future, I should try to remove the m_isNavigationHandledByClient as
soon as I understood better how the frameloader works and how it is connected to
the testrunner.

[Nate Chapin, 2017-01-18 21:58:12]

On 2017/01/12 12:33:29, arthursonzogni wrote:
> Thanks!
> A comment below:
> 
>
https://codereview.chromium.org/2624723002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):
> 
>
https://codereview.chromium.org/2624723002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/loader/FrameLoader.cpp:1464:
> m_isNavigationHandledByClient = false;
> On 2017/01/11 20:30:46, Nate Chapin wrote:
> > This isn't obvious to me. A blink-internal navigation failed, why would an
> > external navigation also fail?
> 
> If an external navigation is in progress, what other kind of load could fail?
I
> don't know how it works, but I expected that there could be only one thing to
> load at a time.

A committed DocumentLoader can fail late in its loading process, which is
admittedly fairly rare.

> 
> If this is not a good idea to put it here, I can move this statement in the
> upper level:
> * 0) FrameLoader::loadFailed()
> * 1) WebLocalFrameImpl::maybeRenderFallbackContent()
> * 2) RenderFrameImpl::OnFailedNavigation()
> 
> But I will need to create functions to set m_isNavigationHandledByClient from
> outside of the FrameLoader. Do you think to put this line of code in 1) is
okay?
> 
> Note: In the future, I should try to remove the m_isNavigationHandledByClient
as
> soon as I understood better how the frameloader works and how it is connected
to
> the testrunner.
 I'm suspicious that (1) is the only case where it's needed. A public function
on FrameLoader like clearNavigationHandledByClient() would be OK.

[arthursonzogni, 2017-01-19 09:19:19]

The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 09:19:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[arthursonzogni, 2017-01-19 09:19:53]

I applied your suggestion. Thanks!

[commit-bot: I haz the power, 2017-01-19 11:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 11:21:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_browser_side_navigation_rel on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[arthursonzogni, 2017-01-19 12:28:32]

The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run

[arthursonzogni, 2017-01-19 12:28:39]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-19 12:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 15:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 15:07:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_browser_side_navigation_rel on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2017-01-24 23:38:12]

lgtm

[arthursonzogni, 2017-01-25 08:44:13]

The CQ bit was checked by arthursonzogni@chromium.org

[commit-bot: I haz the power, 2017-01-25 08:44:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 11:55:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485333853783650,
"parent_rev": "af23a0c634f77c940bc54aea0c92880c1f3c4e6c", "commit_rev":
"68693ab02e29631f4b484299fab89a66c768b01f"}

[commit-bot: I haz the power, 2017-01-25 11:56:30]

Description was changed from

==========
PlzNavigate: fix regression on the FYI bot.

It fixes a regression introduced in crrev.com/2563423004 for the
FYI bot: "Browser Side Navigation Linux".
It happens with Failed navigation within <object data=...>.
m_progressTracker->progressCompleted() lines were removed by the
previous commit and further call to it didn't happen with PlzNavigate.
It leads to a timeout in a few tests.

Tests fixed:
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
-
imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

BUG=679675
==========

to

==========
PlzNavigate: fix regression on the FYI bot.

It fixes a regression introduced in crrev.com/2563423004 for the
FYI bot: "Browser Side Navigation Linux".
It happens with Failed navigation within <object data=...>.
m_progressTracker->progressCompleted() lines were removed by the
previous commit and further call to it didn't happen with PlzNavigate.
It leads to a timeout in a few tests.

Tests fixed:
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
-
imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

BUG=679675

Review-Url: https://codereview.chromium.org/2624723002
Cr-Commit-Position: refs/heads/master@{#445997}
Committed:
https://chromium.googlesource.com/chromium/src/+/68693ab02e29631f4b484299fab8...
==========

[commit-bot: I haz the power, 2017-01-25 11:56:31]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/68693ab02e29631f4b484299fab8...