Remove web/{android, gtk, win}

Remove web/{android, gtk, win}

The {android, gtk, win} directories contain only WebInputEventFactory.cpp.
We can just move these files to web/ with files renamed as WebInputEventFactoryAndroid.cpp,
WebInputEventFactoryGtk.cpp, WebInputEventFactoryWin.cpp respectively and remove the dir.
Moved the WebInputEventFactory.mm also to web/ as WebInputEventFactoryMac.mm but since web/mac/
still contains one more file, retained the dir. I will be removing it as part of another CL.

Uploading corrected change.
Original CL - http://crrev.com/27462002/
Revert CL - http://crrev.com/27532002/
Revert Reason - Aura builds failing.

BUG=None

TEST=None;no behavior changes;

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160060

[r.kasibhatla, 2013-10-17 11:04:06]

PTAL.
Addressed the slipup in naming of WebInputEventFactory.mm also (suggested by
tfarina).
@tdanderson: Corrected the patch to fix build failures which were seen with
earlier patch. Tried on various platforms try bots. If I missed any platform
build, can you please trigger that trybot also.

[tfarina, 2013-10-17 11:06:20]

see below.

https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
File Source/web/web.gyp (right):

https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode178
Source/web/web.gyp:178: ['exclude', 'WebInputEventFactoryAndroid.cpp$'],
this shouldn't be necessary, see config.gyp.

[r.kasibhatla, 2013-10-17 13:00:41]

https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
File Source/web/web.gyp (right):

https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode178
Source/web/web.gyp:178: ['exclude', 'WebInputEventFactoryAndroid.cpp$'],
On 2013/10/17 11:06:20, tfarina wrote:
> this shouldn't be necessary, see config.gyp.
In config.gyp, I see only condition for OS==win, where we exclude entire posix/
folder and if not win, we exclude all *Win.cpp files.
I didn't find any conditions which would do the same for GTK or Android or Mac.
Did I miss something?

[tdanderson, 2013-10-17 15:14:45]

On 2013/10/17 11:04:06, r.kasibhatla wrote:
> PTAL.
> Addressed the slipup in naming of WebInputEventFactory.mm also (suggested by
> tfarina).
> @tdanderson: Corrected the patch to fix build failures which were seen with
> earlier patch. Tried on various platforms try bots. If I missed any platform
> build, can you please trigger that trybot also.

The linux_aura trybot is passing here, so LGTM. I have CC'ed
hayato@ and alecflett@ (the current Blink gardeners) so they
are aware you'd like to re-land this.

[tfarina, 2013-10-17 22:10:40]

On Thu, Oct 17, 2013 at 10:00 AM,  <r.kasibhatla@samsung.com> wrote:
>
> https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
> File Source/web/web.gyp (right):
>
>
https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode178
> Source/web/web.gyp:178: ['exclude', 'WebInputEventFactoryAndroid.cpp$'],
> On 2013/10/17 11:06:20, tfarina wrote:
>>
>> this shouldn't be necessary, see config.gyp.
>
> In config.gyp, I see only condition for OS==win, where we exclude entire
> posix/ folder and if not win, we exclude all *Win.cpp files.
> I didn't find any conditions which would do the same for GTK or Android
> or Mac.
> Did I miss something?
>
Yes, I have landed a change that excluded win and android files as
well, but it just got reverted now.

Thanks!

> https://codereview.chromium.org/26247009/



-- 
Thiago

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[r.kasibhatla, 2013-10-18 03:23:04]

On 2013/10/17 22:10:40, tfarina wrote:
> On Thu, Oct 17, 2013 at 10:00 AM,  <mailto:r.kasibhatla@samsung.com> wrote:
> >
> > https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
> > File Source/web/web.gyp (right):
> >
> >
>
https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode178
> > Source/web/web.gyp:178: ['exclude', 'WebInputEventFactoryAndroid.cpp$'],
> > On 2013/10/17 11:06:20, tfarina wrote:
> >>
> >> this shouldn't be necessary, see config.gyp.
> >
> > In config.gyp, I see only condition for OS==win, where we exclude entire
> > posix/ folder and if not win, we exclude all *Win.cpp files.
> > I didn't find any conditions which would do the same for GTK or Android
> > or Mac.
> > Did I miss something?
> >
> Yes, I have landed a change that excluded win and android files as
> well, but it just got reverted now.
> 
> Thanks!
> 
Should I wait till your patch is landed and rework on top of that?
In that scenario, I need not make changes to web.gyp since config.gyp would take
care of things itself.
> > https://codereview.chromium.org/26247009/
> 
> 
> 
> -- 
> Thiago
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

[r.kasibhatla, 2013-10-18 03:23:16]

On 2013/10/17 22:10:40, tfarina wrote:
> On Thu, Oct 17, 2013 at 10:00 AM,  <mailto:r.kasibhatla@samsung.com> wrote:
> >
> > https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
> > File Source/web/web.gyp (right):
> >
> >
>
https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode178
> > Source/web/web.gyp:178: ['exclude', 'WebInputEventFactoryAndroid.cpp$'],
> > On 2013/10/17 11:06:20, tfarina wrote:
> >>
> >> this shouldn't be necessary, see config.gyp.
> >
> > In config.gyp, I see only condition for OS==win, where we exclude entire
> > posix/ folder and if not win, we exclude all *Win.cpp files.
> > I didn't find any conditions which would do the same for GTK or Android
> > or Mac.
> > Did I miss something?
> >
> Yes, I have landed a change that excluded win and android files as
> well, but it just got reverted now.
> 
> Thanks!
> 
@tfarina: Should I wait till your patch is landed and rework on top of that?
In that scenario, I need not make changes to web.gyp since config.gyp would take
care of things itself.
> > https://codereview.chromium.org/26247009/
> 
> 
> 
> -- 
> Thiago
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

[tfarina, 2013-10-18 18:34:10]

On Fri, Oct 18, 2013 at 12:23 AM,  <r.kasibhatla@samsung.com> wrote:
> On 2013/10/17 22:10:40, tfarina wrote:
>>
>> On Thu, Oct 17, 2013 at 10:00 AM,  <mailto:r.kasibhatla@samsung.com>
>> wrote:
>> >
>> > https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
>> > File Source/web/web.gyp (right):
>> >
>> >
>
>
>
https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode178
>>
>> > Source/web/web.gyp:178: ['exclude', 'WebInputEventFactoryAndroid.cpp$'],
>> > On 2013/10/17 11:06:20, tfarina wrote:
>> >>
>> >> this shouldn't be necessary, see config.gyp.
>> >
>> > In config.gyp, I see only condition for OS==win, where we exclude entire
>> > posix/ folder and if not win, we exclude all *Win.cpp files.
>> > I didn't find any conditions which would do the same for GTK or Android
>> > or Mac.
>> > Did I miss something?
>> >
>> Yes, I have landed a change that excluded win and android files as
>> well, but it just got reverted now.
>
>
>> Thanks!
>
>
> @tfarina: Should I wait till your patch is landed and rework on top of that?
>
No, don't feel blocked by that. i.e., don't wait for it to be
relanded. Go ahead with what you have if your reviewers approve.

Thanks,

-- 
Thiago

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-19 00:36:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26247009/4001

[commit-bot: I haz the power, 2013-10-19 00:54:47]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[r.kasibhatla, 2013-10-20 17:15:17]

Added tkent
@tkent,@eseidel: Can anyone of you please give lgtm (need owner lgtm) for
relanding this change.

[tkent, 2013-10-20 23:03:39]

What's the benefit of this CL?
What's wrong with the reverted CL?

https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
File Source/web/web.gyp (right):

https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode193
Source/web/web.gyp:193: ['exclude', 'WebInputEventFactoryGtk.cpp$'],
These exclude looks unnecessary.
For example, If OS==android,
toolkit_uses_gtk!=1, OS!=mac, OS!=win sections exclude each of
WebInputEventFactory*.*.

[r.kasibhatla, 2013-10-21 04:04:44]

On 2013/10/20 23:03:39, tkent wrote:
> What's the benefit of this CL?
The folders web/{gtk, win, android} just contain single files, so moving them to
web/. Removes unneccessary hierarchy of folders.

> What's wrong with the reverted CL?
It was breaking Linux Aura builds. As I didn't exclude the {gtk|win|android}
files, when the target *was not* {gtk|win|android} respectively, they were
getting included in case of aura and the build was failing. Corrected the
excludes in this patch.

> 
> https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
> File Source/web/web.gyp (right):
> 
>
https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode193
> Source/web/web.gyp:193: ['exclude', 'WebInputEventFactoryGtk.cpp$'],
> These exclude looks unnecessary.
> For example, If OS==android,
> toolkit_uses_gtk!=1, OS!=mac, OS!=win sections exclude each of
> WebInputEventFactory*.*.
Agree. Will correct and upload new patch removing unneccessary excludes.

[r.kasibhatla, 2013-10-21 04:05:40]

PTAL.

https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp
File Source/web/web.gyp (right):

https://codereview.chromium.org/26247009/diff/4001/Source/web/web.gyp#newcode193
Source/web/web.gyp:193: ['exclude', 'WebInputEventFactoryGtk.cpp$'],
On 2013/10/20 23:03:40, tkent wrote:
> These exclude looks unnecessary.
> For example, If OS==android,
> toolkit_uses_gtk!=1, OS!=mac, OS!=win sections exclude each of
> WebInputEventFactory*.*.

Done.

[tkent, 2013-10-21 05:26:30]

lgtm

[commit-bot: I haz the power, 2013-10-21 05:26:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26247009/113001

[commit-bot: I haz the power, 2013-10-21 06:22:03]

Change committed as 160060