Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2624693002: Add HeapCompaction FeatureList flag (Closed)

Created:
3 years, 11 months ago by keishi
Modified:
3 years, 11 months ago
Reviewers:
haraken, Charlie Reis
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HeapCompaction FeatureList flag Adds HeapCompaction as a FeatureList flag so it can be enabled from a Finch experiment. BUG=678923 Review-Url: https://codereview.chromium.org/2624693002 Cr-Commit-Position: refs/heads/master@{#443210} Committed: https://chromium.googlesource.com/chromium/src/+/1f5422af8e58fc0b434a644fff16a82652d234cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
keishi
I would like to add HeapCompaction as a FeatureList flag so it can be enabled ...
3 years, 11 months ago (2017-01-10 03:33:46 UTC) #3
haraken
LGTM
3 years, 11 months ago (2017-01-10 03:53:32 UTC) #4
Charlie Reis
LGTM
3 years, 11 months ago (2017-01-10 18:31:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624693002/1
3 years, 11 months ago (2017-01-12 02:06:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/263263)
3 years, 11 months ago (2017-01-12 02:18:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624693002/1
3 years, 11 months ago (2017-01-12 11:08:10 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 11:47:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f5422af8e58fc0b434a644fff16...

Powered by Google App Engine
This is Rietveld 408576698