Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2624663002: Changed uses of deque to vector in chrome/browser/android/data_usage. (Closed)

Created:
3 years, 11 months ago by sclittle
Modified:
3 years, 11 months ago
Reviewers:
Raj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed uses of deque to vector in chrome/browser/android/data_usage. chrome/browser/android/data_usage has a few uses of std::deque that would work just about as well using std::vector, and since std::deque is memory inefficient for small numbers of elements (see http://crbug.com/674287), this CL replaces those uses of std::deque with std::vector. BUG=679568 Review-Url: https://codereview.chromium.org/2624663002 Cr-Commit-Position: refs/heads/master@{#443066} Committed: https://chromium.googlesource.com/chromium/src/+/dfc7302588449730604019c9ca057bcbf83544d0

Patch Set 1 #

Patch Set 2 : fix bad math #

Messages

Total messages: 13 (7 generated)
sclittle
3 years, 11 months ago (2017-01-10 01:24:01 UTC) #2
Raj
On 2017/01/10 01:24:01, sclittle wrote: lgtm
3 years, 11 months ago (2017-01-10 20:29:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624663002/1
3 years, 11 months ago (2017-01-10 20:53:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/210343)
3 years, 11 months ago (2017-01-10 22:12:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624663002/20001
3 years, 11 months ago (2017-01-11 22:45:06 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:09:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dfc7302588449730604019c9ca05...

Powered by Google App Engine
This is Rietveld 408576698