Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: google_apis/gcm/engine/connection_event_tracker.cc

Issue 2624653003: Provide correct guard for GCM connection tracking of login failures. (Closed)
Patch Set: nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/gcm/engine/connection_factory_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/connection_event_tracker.cc
diff --git a/google_apis/gcm/engine/connection_event_tracker.cc b/google_apis/gcm/engine/connection_event_tracker.cc
index cad77ebd37e1387c8c24e1fadc0d7ca85401beaa..d8c3313135f23abc256bb807c1b535449a61d483 100644
--- a/google_apis/gcm/engine/connection_event_tracker.cc
+++ b/google_apis/gcm/engine/connection_event_tracker.cc
@@ -62,8 +62,8 @@ void ConnectionEventTracker::ConnectionAttemptSucceeded() {
void ConnectionEventTracker::ConnectionLoginFailed() {
// A login failure would have originally been marked as a successful
// connection, so now that it failed, that needs to be updated.
- // TODO(harkness): Add back DCHECK which was removed. See
- // https://crbug.com/673706.
+ DCHECK_EQ(current_event_.type(),
+ mcs_proto::ClientEvent::SUCCESSFUL_CONNECTION);
current_event_.set_type(mcs_proto::ClientEvent::FAILED_CONNECTION);
current_event_.clear_time_connection_established_ms();
« no previous file with comments | « no previous file | google_apis/gcm/engine/connection_factory_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698