Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: google_apis/gcm/engine/connection_factory_impl.h

Issue 2624653003: Provide correct guard for GCM connection tracking of login failures. (Closed)
Patch Set: nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/connection_factory_impl.h
diff --git a/google_apis/gcm/engine/connection_factory_impl.h b/google_apis/gcm/engine/connection_factory_impl.h
index ff7de143dc26ab94023d4cb6a1b2091c8ba58ef8..0b8ff17bf796210cc0276b647804f62b778b2ce0 100644
--- a/google_apis/gcm/engine/connection_factory_impl.h
+++ b/google_apis/gcm/engine/connection_factory_impl.h
@@ -183,10 +183,10 @@ class GCM_EXPORT ConnectionFactoryImpl :
// client is informed of a valid connection type.
bool waiting_for_network_online_;
- // Whether login successfully completed after the connection was established.
- // If a connection reset happens while attempting to log in, the current
- // backoff entry is reused (after incrementing with a new failure).
- bool logging_in_;
+ // Whether handshake is in progress after the connection was established. If
+ // a connection reset happens while attempting to complete the handshake, the
+ // current backoff entry is reused (after incrementing with a new failure).
+ bool handshake_in_progress_;
// The time of the last login completion. Used for calculating whether to
// restore a previous backoff entry and for measuring uptime.
« no previous file with comments | « google_apis/gcm/engine/connection_event_tracker.cc ('k') | google_apis/gcm/engine/connection_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698