Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2624613002: Promotes common functions to WmRootWindowController (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promotes common functions to WmRootWindowController Specifically ConfigureWidgetInitParamsForContainer(), FindEventTarget() and GetLastMouseLocation() can be shared. BUG=671246 TEST=none R=msw@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -74 lines) Patch
M ash/aura/wm_root_window_controller_aura.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ash/aura/wm_root_window_controller_aura.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M ash/common/wm_root_window_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/wm_root_window_controller.cc View 1 3 chunks +35 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.cc View 2 chunks +0 lines, -26 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
sky
3 years, 11 months ago (2017-01-09 22:40:39 UTC) #1
msw
lgtm with a nit https://codereview.chromium.org/2624613002/diff/1/ash/common/wm_root_window_controller.cc File ash/common/wm_root_window_controller.cc (right): https://codereview.chromium.org/2624613002/diff/1/ash/common/wm_root_window_controller.cc#newcode247 ash/common/wm_root_window_controller.cc:247: gfx::Point WmRootWindowController::GetLastMouseLocationInRoot() { nit: match ...
3 years, 11 months ago (2017-01-09 23:26:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624613002/20001
3 years, 11 months ago (2017-01-09 23:39:03 UTC) #7
sky
https://codereview.chromium.org/2624613002/diff/1/ash/common/wm_root_window_controller.cc File ash/common/wm_root_window_controller.cc (right): https://codereview.chromium.org/2624613002/diff/1/ash/common/wm_root_window_controller.cc#newcode247 ash/common/wm_root_window_controller.cc:247: gfx::Point WmRootWindowController::GetLastMouseLocationInRoot() { On 2017/01/09 23:26:48, msw wrote: > ...
3 years, 11 months ago (2017-01-09 23:39:12 UTC) #8
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-10 01:08:48 UTC) #11
sky
3 years, 11 months ago (2017-01-10 03:24:31 UTC) #12
On 2017/01/10 01:08:48, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

This landed @ 06af9c916f580de458f256ed0164e92d93350be1.

Powered by Google App Engine
This is Rietveld 408576698